Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobPropertyDescriptor.newInstance can return null #9

Conversation

jglick
Copy link
Member

@jglick jglick commented Oct 27, 2015

Needed for proper Snippet Generator behavior in jenkinsci/pipeline-plugin#209. Something like jenkinsci/jenkins#1656 would have made this more natural.

@reviewbybees esp. @stephenc

@ghost
Copy link

ghost commented Oct 27, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

jglick added a commit to jglick/pipeline-plugin that referenced this pull request Oct 27, 2015
@stephenc
Copy link
Member

🐝

jglick added a commit to jglick/pipeline-plugin that referenced this pull request Oct 27, 2015
@tfennelly
Copy link
Member

🐝

I think a comment in the newInstance method would do no harm i.e. why it returns null when prop.getThrottle() returns null.

@jglick
Copy link
Member Author

jglick commented Oct 27, 2015

Well you can always jump to the super method which explains it. Anyway I intend for the implementation to be replaced when a core API is ready.

jglick added a commit that referenced this pull request Oct 27, 2015
…Impl.DescriptorImpl.newInstance

JobPropertyDescriptor.newInstance can return null
@jglick jglick merged commit 36a6306 into jenkinsci:master Oct 27, 2015
@jglick jglick deleted the RateLimitBranchProperty.JobPropertyImpl.DescriptorImpl.newInstance branch October 27, 2015 17:48
jglick added a commit to jenkinsci/workflow-multibranch-plugin that referenced this pull request Apr 5, 2016
Originally-Committed-As: 37cf6d755583814bf6b539cde7af83883ff3b881
jglick added a commit to jenkinsci/workflow-multibranch-plugin that referenced this pull request Apr 5, 2016
Originally-Committed-As: c96a666d651847d5b2d063285e718516e3ba460a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants