Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating BranchPropertys which do not work with Pipeline #459

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

@jglick jglick added the chore label Jun 4, 2024
@jglick jglick requested a review from a team as a code owner June 4, 2024 17:29
@jglick jglick merged commit a9188b5 into jenkinsci:master Jun 5, 2024
14 checks passed
@jglick jglick deleted the deprecated-branch-properties branch June 5, 2024 20:51
@jonesbusy
Copy link

I'm a bit confused with this deprecation.

I found some of my user jobs (created by JobDSL using such properties)

multibranchPipelineJob("job-name") {
    ....
    branchSources {
        branchSource {
            ...
            strategy {
                ...
                namedBranchesDifferent {
                    defaultProperties {
                        ...
                        buildRetention {
                            buildDiscarder {
                                logRotator {
                                    numToKeepStr("5")
                                    artifactNumToKeepStr("5")
                                    daysToKeepStr("-1")
                                    artifactDaysToKeepStr("-1")
                                }
                            }
                        }
                    }
                }
                ...
            }
        }
    }
    ...
}

Looking at the job configuration it seems to assign properties and works well (looking at the discard of build to 5. Changing the value on the UI and running a branch correctly cleanup build)

property_strategy

I'm probably missing something, but why such deprecation ?

@jglick
Copy link
Member Author

jglick commented Aug 8, 2024

Not sure about job-dsl plugin but this option should not be offered in the GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants