[JENKINS-54128] Avoid calling Run.getLogFile #40
Conversation
|
Awesome, thanks @jglick ! |
| <distribution>repo</distribution> | ||
| </license> | ||
| </licenses> | ||
|
|
||
| <properties> | ||
| <jenkins.version>2.60.3</jenkins.version> | ||
| <jenkins.version>2.121.1</jenkins.version> |
There was a problem hiding this comment.
Let me see.
getLogReader() is already provided in 2.60.3 and there looks no need to upgrade the target version.
Why do you want this change?
There was a problem hiding this comment.
I want to leave target versions as possible to allow users with older Jenkins to install newer versions.
There was a problem hiding this comment.
Why do you want this change?
So that functional tests can verify that it actually works. Plugin versions old enough to be compatible with the 2.60.x line do not include the JEP-210 changes which were the trigger for the issue.
allow users with older Jenkins to install newer versions
Up to you as maintainer. Stats suggest it is pointless as the great majority of users who have even updated to the currently newest plugin version are already on Jenkins 1.121.1 or newer.
There was a problem hiding this comment.
I see. Looks good to me.
Notes:
- Get warned since workflow-job-2.26
- jenkinsci/workflow-job-plugin@e6a58e8
- Targets Jenkins-2.121.1
- Released in 2018-06-07
- https://jenkins.io/changelog-stable/#v2.121.1
- Get deprecated since jenkins-2.171
- jenkinsci/jenkins@870eafe
- Since jenkins-2.176.1 for the LTS line
| <version>1.60</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </dependencyManagement> |
There was a problem hiding this comment.
Note: To avoid RequireUpperBoundDeps:
[WARNING] Rule 4: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for org.jenkins-ci.plugins:structs:1.14 paths to dependency are:
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins:badge:1.2
+-org.jenkins-ci.plugins:structs:1.14
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins.workflow:workflow-cps:2.69
+-org.jenkins-ci.plugins:structs:1.17
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins.workflow:workflow-step-api:2.20
+-org.jenkins-ci.plugins:structs:1.18
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins.workflow:workflow-basic-steps:2.15
+-org.jenkins-ci.plugins:structs:1.17
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins:junit:1.20
+-org.jenkins-ci.plugins:structs:1.2
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins:badge:1.2
+-org.jenkins-ci.plugins.workflow:workflow-step-api:2.14
+-org.jenkins-ci.plugins:structs:1.5
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins.workflow:workflow-cps:2.69
+-org.jenkins-ci.plugins.workflow:workflow-api:2.30
+-org.jenkins-ci.plugins:structs:1.14
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins.workflow:workflow-cps:2.69
+-org.jenkins-ci.plugins:scm-api:2.2.6
+-org.jenkins-ci.plugins:structs:1.9
,
Require upper bound dependencies error for org.jenkins-ci.plugins:script-security:1.39 paths to dependency are:
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins:badge:1.2
+-org.jenkins-ci.plugins:script-security:1.39
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins:matrix-project:1.12
+-org.jenkins-ci.plugins:script-security:1.13
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins.workflow:workflow-cps:2.69
+-org.jenkins-ci.plugins:script-security:1.58
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins.workflow:workflow-cps:2.69
+-org.jenkins-ci.plugins.workflow:workflow-support:3.3
+-org.jenkins-ci.plugins:script-security:1.39
,
Require upper bound dependencies error for org.jenkins-ci.plugins.workflow:workflow-api:2.30 paths to dependency are:
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins.workflow:workflow-cps:2.69
+-org.jenkins-ci.plugins.workflow:workflow-api:2.30
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins.workflow:workflow-job:2.32
+-org.jenkins-ci.plugins.workflow:workflow-api:2.32
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins.workflow:workflow-basic-steps:2.15
+-org.jenkins-ci.plugins.workflow:workflow-api:2.33
and
+-org.jvnet.hudson.plugins:groovy-postbuild:2.5-SNAPSHOT
+-org.jenkins-ci.plugins.workflow:workflow-cps:2.69
+-org.jenkins-ci.plugins.workflow:workflow-support:3.3
+-org.jenkins-ci.plugins.workflow:workflow-api:2.30
It would be warned if versions in dependencyManagement is older than actual required ones, and this is enough safe even when updating dependency versions.
There was a problem hiding this comment.
But there looks artifacts not warned in RequireUpperBoundDeps.
And the versions looks newer than required ones.
With what policy do you specify these versions?
I want to know the best practice to avoid RequireUpperBoundDeps.
There was a problem hiding this comment.
With what policy do you specify these versions?
I simply put managed versions of dependencies as new as RequireUpperBoundDeps errors requested, until there no more such errors.
| <dependency> | ||
| <groupId>org.jenkins-ci.plugins</groupId> | ||
| <artifactId>script-security</artifactId> | ||
| <version>1.60</version> |
There was a problem hiding this comment.
(This is just a note, not a change request)
Groovy-postbuild depends directly and enormously on script-security, and should depend on script-security explicitly and declare the same version in tests.
It’s removed from dependencies when extracting badge-plugin.
I’ll review dependencies after merging this and #42 .
* I fond that doesn't affect plugin dependencies.
|
Released in groovy-postbuild-2.5. |
JENKINS-54128 for this plugin. @vmassol