[JENKINS-57917] Add AddHtmlBadge feature
#42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikedam
commented
Jun 8, 2019
| @@ -35,7 +35,7 @@ | |||
| <properties> | |||
| <jenkins.version>2.60.3</jenkins.version> | |||
| <java.level>8</java.level> | |||
| <badge-plugin.version>1.2</badge-plugin.version> | |||
| <badge-plugin.version>1.5</badge-plugin.version> | |||
There was a problem hiding this comment.
addHtmlBadge is introduced in 1.3.
There's a security fix in 1.5.
There was a problem hiding this comment.
Why don't you switch to the latest version?
There was a problem hiding this comment.
As I consider those definitions for other plugins as requirements rather than dependencies in standard Java projects.
ikedam
commented
Jun 8, 2019
| @@ -491,6 +492,95 @@ public void testBadgeMigration() throws Exception { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void testAddShortText() throws Exception { | |||
There was a problem hiding this comment.
Though tests for AddShortText is not directly related to this request,
I added those tests in this request as the unexpected regression was caused
for there was no test codes for badge-related features.
ikedam
force-pushed
the
feature/JENKINS-57917_AddHtmlBadge
branch
from
42f7b8f
to
b5e678a
Compare
|
Rebased to resolve conflict with #40 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jenkins-ci.org/browse/JENKINS-57917
Added
AddHtmlBadgeto groovy-postbuild as a wrapper for the same feature of badge-plugin.Existing badge features in groovy-postbuild doesn't accept HTML texts since 2.4.
Actually, that was unexpected regression introduced by my fault, but I didn't revert that for security reasons.
This provides an alternate way to use HTML for users used HTML texts in groovy-postbuild before 2.4.