Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #43

Merged
merged 2 commits into from
Jun 24, 2019
Merged

Update dependencies #43

merged 2 commits into from
Jun 24, 2019

Conversation

ikedam
Copy link
Member

@ikedam ikedam commented Jun 15, 2019

  • Declared directly required versions in <dependencies> section.
    • "directly required" means "referenced from codes".
      • E.g. Added script-security as groovy-script uses SecureGroovyScript.
    • Removed workflow-step-api and junit-plugin as groovy-script itself doesn't use it even in tests.
      • RequireUpperBoundDeps problems are resolved with <dependencyManagement>.
  • Reordered dependencies. Mandatory dependencies, optional dependencies and test dependencies.
  • Use the least versions for depending plugins as they are considered requirements.
  • Removed properties to specify dependency versions.
    • No longer necessary as they are used to synchronize versions for artifacts without classifier and with classifier=tests.

@ikedam
Update dependencies
d9f5215 
* Declared directly required versions in the dependencies section.
    * Added script-security as groovy-script utilizes it.
    * Removed workflow-step-api as groovy-script itself doesn't use it even in tests.
* Reordered dependencies. Mandatory dependencies, optional dependencies and test dependencies.
* Use the least versions.
    * workflow-job-2.26 is required to test JENKINS-54128.
* Removed properties to specify dependency versions.
    * No longer necessary as they are used to synchronize versions for artifacts without classifier and with classifier=tests.
@ikedam
Use workflow-job-2.32 same as used in jenkinsci#40
6db9feb 
* I fond that doesn't affect plugin dependencies.
@ikedam ikedam mentioned this pull request Jun 15, 2019
Merged
@ikedam ikedam merged commit c0fc933 into jenkinsci:master Jun 24, 2019
@MarkEWaite MarkEWaite added the dependencies Dependency related change label Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Dependency related change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikedam @MarkEWaite