Internalize pluralization #161
Conversation
|
@pjmorse this is one of the big ones for 2.9 |
|
OK. I'll give it some chewing. |
| @@ -33,7 +35,7 @@ | |||
| 'az', 'bm', 'my', 'zh', 'dz', 'ka', 'hu', 'ig', 'id', 'ja', 'jv', 'kea', | |||
| 'kn', 'km', 'ko', 'ses', 'lo', 'kde', 'ms', 'fa', 'root', 'sah', 'sg', | |||
| 'ii', 'th', 'bo', 'to', 'tr', 'vi', 'wo', 'yo' | |||
| ], function(n) { | |||
| ], function(/* n */) { | |||
There was a problem hiding this comment.
This is just to make JSHint happy.
jamesarosen
force-pushed
the
james/internalize-plurals
branch
2 times, most recently
from
7af5ed4
to
1f16dc9
Compare
| @@ -25,6 +25,7 @@ test: development_dependencies | |||
| @./script/run.js | |||
|
|
|||
| vendor_install: development_dependencies | |||
| @mkdir -p ./vendor | |||
There was a problem hiding this comment.
The Travis build was breaking. I thought Travis was trolling me with some weird connectivity problem. It turns out vendor/ isn't in the git repo now that I removed vendor/cldr.js.
|
Looks good so far. I'm going to spin up a quick demo app to make myself more confident. |
|
Aside from the backwards-compatibility thing, this looks 👍 to me. |
* remove dependency on `CLDR.js` * add `lib/i18n-plurals.js` with pluralization logic, to be included after `lib/i18n.js` * add deprecation warning if `window.CLDR` is defined * look for current locale in `Ember.I18n.currentLocale` before falling back on `CLDR.defaultLanguage` * Change README to describe new process to add pluralization support Closes #46 See also #49
jamesarosen
force-pushed
the
james/internalize-plurals
branch
from
1f16dc9
to
e9aadb4
Compare
|
No, I think that's a good plan. I can imagine #149 going in on the v2-stable branch - that seems broadly useful to people who aren't on a new enough Ember version to need 3.x - but that shouldn't stop you tagging, releasing, and starting on the 3.0 tasks. |
CLDR.jslib/i18n-plurals.jswith pluralization logic, to be included afterlib/i18n.jswindow.CLDRis definedEmber.I18n.currentLocalebefore falling back onCLDR.defaultLanguageCloses #46
See also #49