This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
Don't expose CLDR.defaultLocale #49
Milestone
Comments
jamesarosen
added a commit
that referenced
this issue
Oct 20, 2014
* remove dependency on `CLDR.js` * add `lib/i18n-plurals.js` with pluralization logic, to be included after `lib/i18n.js` * add deprecation warning if `window.CLDR` is defined * look for current locale in `Ember.I18n.currentLocale` before falling back on `CLDR.defaultLanguage` * Change README to describe new process to add pluralization support Closes #46 See also #49
jamesarosen
added a commit
that referenced
this issue
Oct 20, 2014
* remove dependency on `CLDR.js` * add `lib/i18n-plurals.js` with pluralization logic, to be included after `lib/i18n.js` * add deprecation warning if `window.CLDR` is defined * look for current locale in `Ember.I18n.currentLocale` before falling back on `CLDR.defaultLanguage` * Change README to describe new process to add pluralization support Closes #46 See also #49
jamesarosen
added a commit
that referenced
this issue
Oct 20, 2014
* remove dependency on `CLDR.js` * add `lib/i18n-plurals.js` with pluralization logic, to be included after `lib/i18n.js` * add deprecation warning if `window.CLDR` is defined * look for current locale in `Ember.I18n.currentLocale` before falling back on `CLDR.defaultLanguage` * Change README to describe new process to add pluralization support Closes #46 See also #49
jamesarosen
added a commit
that referenced
this issue
Oct 20, 2014
* remove dependency on `CLDR.js` * add `lib/i18n-plurals.js` with pluralization logic, to be included after `lib/i18n.js` * add deprecation warning if `window.CLDR` is defined * look for current locale in `Ember.I18n.currentLocale` before falling back on `CLDR.defaultLanguage` * Change README to describe new process to add pluralization support Closes #46 See also #49
|
Resolved in #164 |
chrmod
pushed a commit
to chrmod/ember-i18n
that referenced
this issue
Dec 16, 2014
* remove dependency on `CLDR.js` * add `lib/i18n-plurals.js` with pluralization logic, to be included after `lib/i18n.js` * add deprecation warning if `window.CLDR` is defined * look for current locale in `Ember.I18n.currentLocale` before falling back on `CLDR.defaultLanguage` * Change README to describe new process to add pluralization support Closes jamesarosen#46 See also jamesarosen#49
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See #46
If the CLDR pluralization rules are bundled with this repository, we shouldn't expose
CLDR.defaultLocale. @heartsentwined did this in #44 by introducingEmber.I18n.Config.locale. I might preferEmber.I18n.localeorEmber.I18n.config.locale, but the idea of hiding this dependency seems good.The text was updated successfully, but these errors were encountered: