Simple ember-cli support. #149

chrmod · 2014-10-06T21:44:59Z

It is very simple ember-cli support that uses addon mechanism.

When used in ember-cli project it:

provide a generator to install cldr and ember-i18n as bower components
imports cldr and ember-cli to application build
setup configuration

To use it in ember-cli project:

npm install ember-i18n --save-dev
ember generate ember-i18n

Implements issue: #129

chrmod · 2014-10-06T21:48:59Z

What I see as a must have is a convention on where translation files should be stored within ember-cli project. Following rails way it can be config/locales. Then we need to decide how those should be imported and used inside the project. Maybe a blueprint for initializer can be helpful for some people or just a readme.

hhff · 2014-10-08T04:59:25Z

great work @chrmod ! Personally I think the path to locales should be configured here (ember cli is all about convention over configuration) but should have the ability to be changed via environment.js

config/locales would sounds rad ideal

givanse · 2014-10-17T21:48:20Z

👍

jamesarosen · 2014-10-19T17:01:57Z

Can you take a look at #156 ? If we end up dropping support for Ember 1.9+ in the Ember-I18n v2.x series, do we need to do something to the package.json here?

jamesarosen · 2014-10-19T17:06:23Z

lib/ember-addon/blueprints/ember-i18n/index.js

+  },
+
+  afterInstall: function() {
+    return this.addBowerPackageToProject('ember-i18n', '2.2.2');


Can this be more generic so we don't have to change this every time we release a new version?

Alternatively, it might be time to write a script to bump versions everywhere.

jamesarosen · 2014-10-20T15:44:40Z

lib/ember-addon/index.js

+        ]
+      }
+    });
+  }


I'm hoping to get #161 merged today. That removes the dependency on CLDR.js and adds a new lib/i18n-plurals.js. I suspect this will need to be

included: function(app) { this._super.included(app); this.app.import(app.bowerDirectory + '/ember-i18n/lib/i18n.js', { exports: { 'ember-i18n': [ 'default' ] } }); this.app.import(app.bowerDirectory + '/ember-i18n/lib/i18n-plurals.js'); }

(The pluralization is still an optional separate add-on, but it comes after the core I18n definition.)

chrmod · 2014-11-01T17:21:35Z

lib/ember-addon/blueprints/ember-i18n/index.js

+  },
+
+  afterInstall: function() {
+    return this.addBowerPackageToProject('ember-i18n');


Without any version specified, bower.json will be updated to most recent one.

Right now it asks me to choose from:

conflict Unable to find suitable version for ember-i18n 1) ember-i18n 2.2.2 2) ember-i18n ~2.9.0 [?] Answer: 1

It ignored my selected option and wrote ~2.9.0 to my bower file.

It reproduces after:

rm -rf bower_components/ember-i18n/ bower cache clean ember generate ember-i18n

Results:

grep ember-i18n bower.json "ember-i18n": "~2.9.0" cat bower_components/ember-i18n/VERSION 2.2.2 # bower.json disagrees ls bower_components/ember-i18n/lib/ i18n.js # no ember-addon/ folder :(

This is tricky. What do we do with 3.0.0-beta1? Do we need to hardcode a version string in here? If so, I would prefer something like "~2" for the 2.x branch and "~3" for the 3.x branch.

@givanse if bower askes you to choose a version it means some of your dependencies requires different version. To make bower auto choose the your version of choice you must list it in "resolutions" property of bower.json. In the end you app will use the version it finds in bower_components.

@jamesarosen @givanse please note that while we have addon code in ember-i18n repository, the ember-cli will use to separate copies of ember-i18n, potentially in different version.

To use ember-i18n in the application, it must be listed in bower.json as dependecy.
Next an addon code need to include this bower dependency to ember-cli build. To make it happen addon must be listed as dev-dependecy in package.json (ember-cli automatically scans all node packages for addon code).

It may happen that you will have a different version of ember-i18n in your node_modules directory then in bower_components directory. Apparantly it is the way those things are working if the addon code shares the same repository as library. We can ofcouse separate those competences, but it does not make much sense for me as ember-i18n cannot be used outside of ember.

chrmod · 2014-11-01T17:27:05Z

@jamesarosen please take a look now

jamesarosen · 2014-12-13T17:59:07Z

Can you try updating this to 3.0.0-beta2? If we can get that working, I'd very much like to ship this as part of 3.0.0 :)

chrmod · 2014-12-16T22:38:25Z

@jamesarosen Have tested this setup with 2.9.0 and current master (3.0.0-beta.2) on top of Ember 1.8 with Handlebars 1.3. Both simple translations and pluralization worked well.

jamesarosen · 2014-12-24T21:23:00Z

lib/ember-addon/index.js

+      EmberENV: {
+        FEATURES: {
+          I18N_COMPILE_WITHOUT_HANDLEBARS: true,
+          I18N_TRANSLATE_HELPER_SPAN: false


These flags are no longer necessary.

vire · 2015-02-03T14:58:27Z

Guys, is there any update where this PR could be merged or further processed to get ember-i18n working with ember CLI?

mjperrone · 2015-02-05T16:13:04Z

+1

tristanseifert · 2015-02-06T04:46:05Z

+1

Would definitely love to see this integrated as soon as possible. Let me know how I can be of assistance!

pjmorse · 2015-02-06T14:23:56Z

Given that there's discussion happening in the PR linked above (on Dockyard's ember-cli-i18n project) about merging/collaborating/something with an existing ember-cli-supporting project, I can see why @jamesarosen and/or @chrmod aren't pushing this forward at the moment. It sort of looks to me like this particular branch could be minimally usable if it's rebased and the extraneous configuration flags removed? I have a hack day coming at work on Monday (9 February), so I can try to get a working branch based on this then, if nobody has done it sooner.

jamesarosen · 2015-02-06T17:46:41Z

I'm finally working on an Ember-CLI-based project, so I may be able to pick this back up. I'd really like to get it in for v3.0.

vire · 2015-02-06T18:35:40Z

@jamesarosen 👍

Is there somethink i/we could help you with? some taks/issues etc?

pjmorse · 2015-02-09T15:55:55Z

I've got a fork of this branch rebased and tweaked in #192.

mansona · 2015-02-13T12:14:20Z

So does this mean that this PR can be closed now?

pjmorse · 2015-02-13T15:27:55Z

It's redundant with #192, but since that's not ready to merge yet either I left this open in case @chrmod wanted to pick it back up.

chrmod · 2015-02-14T10:40:24Z

@jamesarosen please see my comments #192 (comment). The work of @pjmorse is absolutely functional as a minimal addon.

If we can improve something it is a README. It seems to me that people that want to use this addon do not feel very comoftable with ember-cli and that is why there are some many questions and misconception about how the addon is suppose to work.

Key to improve the addon is to make people use it and this will happen as soon ember-addon keyword will land in node modules registry. We can improve the addon over time, I do not see the reason to wait any longer.

PS. I've sent you an email to your zendesk inbox but received delivery error. I think we can talk this subject trough, here is my email: krzysztof(dot)modras(at)gmail(dot)com - let talk via skype or hangout, ok?

chrmod · 2015-02-17T21:55:18Z

guess this one can be closed now

chrmod force-pushed the ember-cli-addon branch from 651e837 to a05cfba Compare October 6, 2014 22:14

chrmod mentioned this pull request Oct 8, 2014

use ember-i18n with ember-cli #98

Closed

jamesarosen reviewed Oct 19, 2014
View reviewed changes

pjmorse force-pushed the master branch from 18c85a2 to 17fa08e Compare October 20, 2014 13:58

jamesarosen reviewed Oct 20, 2014
View reviewed changes

pjmorse mentioned this pull request Oct 20, 2014

Internalize pluralization #161

Merged

chrmod force-pushed the ember-cli-addon branch from a05cfba to 2b66efe Compare November 1, 2014 17:16

Simple ember-cli support.

1a64372

chrmod force-pushed the ember-cli-addon branch from 2b66efe to 1a64372 Compare November 1, 2014 17:21

chrmod reviewed Nov 1, 2014
View reviewed changes

jamesarosen reviewed Dec 24, 2014
View reviewed changes

pjmorse mentioned this pull request Feb 9, 2015

Minimal ember-cli addon #192

Merged

chrmod closed this Feb 17, 2015

chrmod deleted the ember-cli-addon branch February 17, 2015 21:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simple ember-cli support. #149

Simple ember-cli support. #149

chrmod commented Oct 6, 2014

chrmod commented Oct 6, 2014

hhff commented Oct 8, 2014

givanse commented Oct 17, 2014

jamesarosen commented Oct 19, 2014

jamesarosen Oct 19, 2014

jamesarosen Oct 20, 2014

chrmod Nov 1, 2014

givanse Nov 7, 2014

givanse Nov 7, 2014

jamesarosen Nov 10, 2014

chrmod Dec 16, 2014

chrmod Dec 16, 2014

chrmod commented Nov 1, 2014

jamesarosen commented Dec 13, 2014

chrmod commented Dec 16, 2014

jamesarosen Dec 24, 2014

vire commented Feb 3, 2015

mjperrone commented Feb 5, 2015

tristanseifert commented Feb 6, 2015

pjmorse commented Feb 6, 2015

jamesarosen commented Feb 6, 2015

vire commented Feb 6, 2015

pjmorse commented Feb 9, 2015

mansona commented Feb 13, 2015

pjmorse commented Feb 13, 2015

chrmod commented Feb 14, 2015

chrmod commented Feb 17, 2015

Simple ember-cli support. #149

Simple ember-cli support. #149

Conversation

chrmod commented Oct 6, 2014

chrmod commented Oct 6, 2014

hhff commented Oct 8, 2014

givanse commented Oct 17, 2014

jamesarosen commented Oct 19, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrmod commented Nov 1, 2014

jamesarosen commented Dec 13, 2014

chrmod commented Dec 16, 2014

Choose a reason for hiding this comment

vire commented Feb 3, 2015

mjperrone commented Feb 5, 2015

tristanseifert commented Feb 6, 2015

pjmorse commented Feb 6, 2015

jamesarosen commented Feb 6, 2015

vire commented Feb 6, 2015

pjmorse commented Feb 9, 2015

mansona commented Feb 13, 2015

pjmorse commented Feb 13, 2015

chrmod commented Feb 14, 2015

chrmod commented Feb 17, 2015