Use LibVLC via WebChimera.js instead of VLC through its HTTP API #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Hopefully fixes audio volume not being set to 50% at startup. - Volume now is in the range of 0 to 200 (percentage, so goes from 0% to 200% for those numbers). - Made message displaying volume change display the actual level set. - We're no longer providing an HTTP interface. - Now stores metadata info in a separate variable for later retrieval by input MRL. - Now prints when player reaches end of playlist. - Now supports toggle-pausing using "pause" command. - Should fix playlist not being able to kick off on "play" if stopped. - Removed vlc-api dependency. Relates to issues #17, #10 and #7 (partially).
Got the documentation wrong here, I was looking up examples and it looked as if calling the on* fields as functions was the right way to go but it was actually not. https://github.com/RSATom/WebChimera.js/blob/64bf4ffc362898e309c8a444c8888ad7b4bfae92/src/JsVlcPlayer.cpp#L90-L102 clearly defines as set-properties here.
Those values are not supposed to be accepted in the first place...
These commands allow going to the previous entry in the playlist.
These commands allow emptying the current playlist. Here another reminder to implement a proper permission system soon!
These commands make the bot print out the current playlist in the channel chat. The current track being played back is printed in bold green font.
This command allows looping the playlist by just passing the command "loop on". Respectively, "loop off" turns off looping again.
This command allows stopping the playlist after the current playlist item is finished.
…ssages, commenting out for now.
onEndReached does not just trigger the callback at the end of the playlist but actually at the end of each track. This should have been better documented.
icedream
added a commit
that referenced
this pull request
Oct 27, 2015
Use LibVLC via WebChimera.js instead of VLC through its HTTP API. This closes #17 and fixes #10, finishes two tasks of #2 and actually solves a few additional issues like: - Not being able to resume playback from a stopped playlist. - Unclear and buggy definition of volume range. - Bot just showing "playing next playlist entry" instead of actually showing the title of the next playlist entry. - Missing "previous" command to go to previous playlist entry. - Missing "loop" command to loop the playlist. (Now exists in form of "loop on"/"loop off") - Missing "stop-after" command to stop playback after current track ends. - A small bug in ts3query.iced that didn't escape line breaks. (Was in use here for "playlist"/"list" commands which got removed in the process.) Known issues: - Starting with an empty playlist, adding an entry and then typing "next" will automatically play the first entry. This is not really a bug or even an issue but definitely unexpected behavior that is coming from VLC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #17 and #10, finishes two tasks of #2 and actually solves a few additional issues like:
Known issues: