Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LibVLC via WebChimera.js instead of VLC through its HTTP API #20

Merged
merged 20 commits into from
Oct 27, 2015

Commits on Oct 26, 2015

  1. Configuration menu
    Copy the full SHA
    ac3531a View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2015

  1. We're now completely getting rid of vlc-api.

    - Hopefully fixes audio volume not being set to 50% at startup.
    - Volume now is in the range of 0 to 200 (percentage, so goes from 0% to 200% for those numbers).
    - Made message displaying volume change display the actual level set.
    - We're no longer providing an HTTP interface.
    - Now stores metadata info in a separate variable for later retrieval by input MRL.
    - Now prints when player reaches end of playlist.
    - Now supports toggle-pausing using "pause" command.
    - Should fix playlist not being able to kick off on "play" if stopped.
    - Removed vlc-api dependency.
    
    Relates to issues #17, #10 and #7 (partially).
    icedream committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    394b16a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e923f80 View commit details
    Browse the repository at this point in the history
  3. VLC event members are actually properties, not functions.

    Got the documentation wrong here, I was looking up examples and it looked as if calling the on* fields as functions was the right way to go but it was actually not. https://github.com/RSATom/WebChimera.js/blob/64bf4ffc362898e309c8a444c8888ad7b4bfae92/src/JsVlcPlayer.cpp#L90-L102 clearly defines as set-properties here.
    icedream committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    8520523 View commit details
    Browse the repository at this point in the history
  4. Fix non-numeric volume value being passed through to VLC as NaN.

    Those values are not supposed to be accepted in the first place...
    icedream committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    8ab5244 View commit details
    Browse the repository at this point in the history
  5. Implement "prev"/"previous" commands.

    These commands allow going to the previous entry in the playlist.
    icedream committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    824b4b9 View commit details
    Browse the repository at this point in the history
  6. Implement "empty"/"clear" commands.

    These commands allow emptying the current playlist. Here another reminder to implement a proper permission system soon!
    icedream committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    4eed972 View commit details
    Browse the repository at this point in the history
  7. Implement "list"/"playlist" commands.

    These commands make the bot print out the current playlist in the channel chat. The current track being played back is printed in bold green font.
    icedream committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    cc783d0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ab18c3c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d61d85e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    eb00dc2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    0762d6d View commit details
    Browse the repository at this point in the history
  12. Implement "loop" command.

    This command allows looping the playlist by just passing the command "loop on". Respectively, "loop off" turns off looping again.
    icedream committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    d827211 View commit details
    Browse the repository at this point in the history
  13. Implement "stop-after" command.

    This command allows stopping the playlist after the current playlist item is finished.
    icedream committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    18b7d82 View commit details
    Browse the repository at this point in the history
  14. Playlist display (command "list"/"playlist") can generate too long me…

    …ssages, commenting out for now.
    icedream committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    7966bfb View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    b238a65 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a5a8ae1 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    9417e33 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    4d25c2b View commit details
    Browse the repository at this point in the history
  19. Completely remove handler for vlc.onEndReached.

    onEndReached does not just trigger the callback at the end of the playlist but actually at the end of each track. This should have been better documented.
    icedream committed Oct 27, 2015
    Configuration menu
    Copy the full SHA
    f315785 View commit details
    Browse the repository at this point in the history