Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playlist system #2

Closed
4 tasks done
icedream opened this issue Oct 16, 2015 · 1 comment
Closed
4 tasks done

Playlist system #2

icedream opened this issue Oct 16, 2015 · 1 comment
Assignees
@icedream
Labels
category/playlisting priority/high status/fixed type/feature
Milestone
Release v0.3

Comments

@icedream
Copy link
Owner

Implement a way to append songs and go forward/backwards. This way we can pretty much just queue songs and let the bot handle the sequential playback instead of having to manually type "play" all the time.

  • Implement "append" ("enqueue"/"add") command
  • Implement "next" command
  • Implement "previous" command
  • Implement separate commands to clear the playlist
  • Implement support for URLs linking to playlists
@icedream icedream self-assigned this Oct 21, 2015
@icedream icedream added this to the Release v0.3 milestone Oct 21, 2015
@icedream
Copy link
Owner Author

Before I gonna tackle this I will do issue #17 so we get more grip on the playlist data.

@icedream icedream mentioned this issue Oct 27, 2015
Merged
icedream added a commit that referenced this issue Oct 27, 2015
@icedream
Merge pull request #20 from icedream/impl/webchimera
034d12d 
Use LibVLC via WebChimera.js instead of VLC through its HTTP API.

This closes #17 and fixes #10, finishes two tasks of #2 and actually solves a few additional issues like:

- Not being able to resume playback from a stopped playlist.
- Unclear and buggy definition of volume range.
- Bot just showing "playing next playlist entry" instead of actually showing the title of the next playlist entry.
- Missing "previous" command to go to previous playlist entry.
- Missing "loop" command to loop the playlist. (Now exists in form of "loop on"/"loop off")
- Missing "stop-after" command to stop playback after current track ends.
- A small bug in ts3query.iced that didn't escape line breaks. (Was in use here for "playlist"/"list" commands which got removed in the process.)

Known issues:
- Starting with an empty playlist, adding an entry and then typing "next" will automatically play the first entry. This is not really a bug or even an issue but definitely unexpected behavior that is coming from VLC.
@icedream icedream mentioned this issue Nov 5, 2015
Open
@icedream icedream closed this as completed Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icedream icedream

Labels
category/playlisting priority/high status/fixed type/feature
Projects
None yet
Milestone
Release v0.3
Development

No branches or pull requests
1 participant
@icedream