Remove hardcoded AMI IDs from spot fleet request #14083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
size/M
YakDriver
changed the title
YakDriver
force-pushed
the
spoflereq
branch
5 times, most recently
from
b0eef7f
to
bec1847
Compare
ghost
added
size/L
|
Added stats above. |
ghost
added
size/M
YakDriver
changed the title
YakDriver
force-pushed
the
spoflereq
branch
2 times, most recently
from
69ff7bc
to
78ba012
Compare
This was referenced Jul 10, 2020
17 tasks
bflad
suggested changes
Jul 23, 2020
ghost
added
size/L
bflad
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
Looks good! 🚀
Output from acceptance testing in AWS Commercial (failure relating to #14265 and being fixed shortly before release):
--- FAIL: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (22.74s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (139.22s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (141.18s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (288.90s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (411.45s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (281.89s)
--- PASS: TestAccAWSSpotFleetRequest_basic (300.22s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (516.37s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (401.37s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (454.99s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (320.19s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (320.10s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (629.76s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (220.01s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (542.36s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (249.07s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (248.44s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (299.53s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (220.94s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (243.76s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (455.06s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (281.23s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (216.10s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (411.38s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (57.45s)
--- PASS: TestAccAWSSpotFleetRequest_tags (317.35s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (601.82s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (812.92s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (292.72s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (232.83s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (256.78s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (263.63s)
--- SKIP: TestAccAWSSpotFleetRequest_WithInstanceStoreAmi (0.00s)
Output from acceptance testing in AWS GovCloud (US) (failures related to hardcoded AZ in TestCheckFunc):
--- FAIL: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (269.00s)
--- FAIL: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (390.28s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (271.05s)
--- PASS: TestAccAWSSpotFleetRequest_basic (391.42s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (773.76s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (271.17s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (513.47s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (390.81s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (391.02s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (511.99s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (270.59s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (271.02s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (652.80s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (391.17s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (272.76s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (653.68s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (271.02s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (270.49s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (393.76s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (513.05s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (273.02s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (271.11s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (44.34s)
--- PASS: TestAccAWSSpotFleetRequest_tags (390.87s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (774.17s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (1155.30s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (511.90s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (299.84s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (271.47s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (270.28s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (443.05s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (331.28s)
|
This has been released in version 3.0.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #14067
Central management issue: #12994
Release note for CHANGELOG:
See AWSAT002
Current stats of acceptance tests for this PR:
Standard and us-gov both have flitty errors. 2/5 current errors appear flitty (1 is a bad ARN check, 2 are errors in
tfawsresource.TestCheckTypeSetElemNestedAttrs).