Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded AMI IDs from launch_config data source #14147

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Jul 10, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Central management issue: #12994

Release note for CHANGELOG:

NONE

The output from acceptance testing:

% make testacc TESTARGS='-run=TestAccAWSLaunchConfigurationDataSource_'  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSLaunchConfigurationDataSource_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSLaunchConfigurationDataSource_basic
=== PAUSE TestAccAWSLaunchConfigurationDataSource_basic
=== RUN   TestAccAWSLaunchConfigurationDataSource_securityGroups
=== PAUSE TestAccAWSLaunchConfigurationDataSource_securityGroups
=== CONT  TestAccAWSLaunchConfigurationDataSource_basic
=== CONT  TestAccAWSLaunchConfigurationDataSource_securityGroups
--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (37.22s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (49.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	50.688s

See AWSAT002

Current stats of acceptance tests for this PR:

Partition Passing Failing Test
us-gov 2 0 With-PR
us-gov 0 2 Pre-PR
standard 2 0 With-PR
standard 2 0 Pre-PR

@YakDriver YakDriver requested a review from a team July 10, 2020 21:55
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 10, 2020
@bflad bflad self-assigned this Jul 15, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (13.61s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (22.20s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (6.58s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (7.82s)

@YakDriver YakDriver added this to the v2.70.1 milestone Jul 15, 2020
@YakDriver YakDriver merged commit e003869 into hashicorp:master Jul 15, 2020
@YakDriver YakDriver deleted the hardami_ds_launchconfig branch July 15, 2020 20:00
@ghost
Copy link

ghost commented Aug 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 15, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Aug 27, 2020
@breathingdust breathingdust modified the milestones: v2.70.1, v3.0.0 Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants