Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite TypeSet checks with helpers [Part 6] #14067

Merged
merged 15 commits into from
Jul 9, 2020
Merged

Rewrite TypeSet checks with helpers [Part 6] #14067

merged 15 commits into from
Jul 9, 2020

Conversation

appilon
Copy link
Contributor

@appilon appilon commented Jul 6, 2020

Final PR rewriting TypeSet checks with the new helpers. A few edgecases have been encountered and are marked with

// TODO: TypeSet ...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@appilon appilon requested a review from a team July 6, 2020 22:29
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/kms Issues and PRs that pertain to the kms service. service/mq Issues and PRs that pertain to the mq service. service/neptune Issues and PRs that pertain to the neptune service. service/opsworks Issues and PRs that pertain to the opsworks service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/route53 Issues and PRs that pertain to the route53 service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/s3 Issues and PRs that pertain to the s3 service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/ssm Issues and PRs that pertain to the ssm service. service/storagegateway Issues and PRs that pertain to the storagegateway service. service/waf Issues and PRs that pertain to the waf service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 6, 2020
@YakDriver YakDriver mentioned this pull request Jul 8, 2020
Merged
@bflad bflad mentioned this pull request Jul 8, 2020
Closed
18 tasks
appilon and others added 8 commits July 8, 2020 20:34
@appilon @anGie44
Update aws/resource_aws_wafv2_web_acl_test.go
31021fc 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@appilon @anGie44
Update aws/resource_aws_wafv2_web_acl_test.go
6603107 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@appilon @anGie44
Update aws/resource_aws_wafv2_web_acl_test.go
bd329da 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@appilon @anGie44
Update aws/resource_aws_instance_test.go
26743f1 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@appilon @anGie44
Update aws/resource_aws_kms_grant_test.go
2384905 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@appilon @anGie44
Update aws/resource_aws_lb_listener_rule_test.go
0b8679f 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@appilon @anGie44
Update aws/resource_aws_opsworks_application_test.go
31cdc3d 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
@appilon @anGie44
Update aws/resource_aws_network_acl_test.go
755aa1f 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
anGie44
anGie44 reviewed Jul 9, 2020
View reviewed changes
aws/resource_aws_instance_test.go Outdated
Steps: []resource.TestStep{
{
Config: testAccInstanceConfigEbsBlockDeviceKmsKeyArn,
Check: resource.ComposeTestCheckFunc(
testAccCheckInstanceExists(resourceName, &instance),
resource.TestCheckResourceAttr(resourceName, "ebs_block_device.#", "1"),
tfawsresource.TestCheckTypeSetElemNestedAttrs(resourceName, "ebs_block_device.*", map[string]string{
"encrypted": "true",
}),
resource.TestCheckResourceAttr(resourceName, "ebs_block_device.2634515331.encrypted", "true"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can now be removed :)

anGie44
anGie44 approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last comment and run of go fmt (that one's my doing from a suggested change :/) otherwise looks great! 🚀 🎉

Output of acceptance tests previously failing:

--- PASS: TestAccAWSInstance_blockDevices (198.35s)
--- PASS: TestAccAWSKmsGrant_withConstraints (51.70s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern_deprecated (209.61s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdatePathPattern_deprecated (271.39s)
--- PASS: TestAccAWSNetworkAcl_EgressAndIngressRules (34.30s)
--- PASS: TestAccAWSOpsworksApplication_basic (68.87s)

Output of other acceptance tests:

--- PASS: TestAccAWSInstanceDataSource_PlacementGroup (65.39s)
--- PASS: TestAccAWSInstanceDataSource_keyPair (90.31s)
--- PASS: TestAccAWSInstanceDataSource_creditSpecification (92.19s)
--- PASS: TestAccAWSInstanceDataSource_VPCSecurityGroups (92.93s)
--- PASS: TestAccAWSInstanceDataSource_RootBlockDevice_KmsKeyId (99.10s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_basic (9.59s)
--- PASS: TestAccAWSInstanceDataSource_gp2IopsDevice (103.07s)
--- PASS: TestAccAWSInstanceDataSource_EbsBlockDevice_KmsKeyId (104.93s)
--- PASS: TestAccAWSInstanceDataSource_rootInstanceStore (111.44s)
--- PASS: TestAccAWSLaunchConfigurationDataSource_securityGroups (12.47s)
--- PASS: TestAccAWSInstanceDataSource_blockDevices (113.26s)
--- PASS: TestAccAWSInstanceDataSource_VPC (119.74s)
--- PASS: TestAccAWSInstanceDataSource_basic (121.94s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData_NoUserData (122.30s)
--- PASS: TestAccAWSInstanceDataSource_GetUserData (125.47s)
--- PASS: TestAccAWSInstanceDataSource_tags (128.82s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_trueToFalse (132.88s)
--- PASS: TestAccAWSInstanceDataSource_privateIP (141.22s)
--- PASS: TestAccAWSAutoScalingGroup_namePrefix (39.09s)
--- PASS: TestAccAWSInstanceDataSource_SecurityGroups (150.95s)
--- PASS: TestAccAWSInstanceDataSource_getPasswordData_falseToTrue (151.80s)
--- PASS: TestAccAWSAutoScalingGroup_terminationPolicies (40.52s)
--- PASS: TestAccAWSAutoScalingGroup_autoGeneratedName (51.27s)
--- PASS: TestAccAWSAutoScalingGroup_VpcUpdates (54.01s)
--- PASS: TestAccAWSAutoScalingGroup_MaxInstanceLifetime (43.02s)
--- PASS: TestAccAWSAutoScalingGroup_withMetrics (54.81s)
--- PASS: TestAccAWSAutoScalingGroup_serviceLinkedRoleARN (46.05s)
--- PASS: TestAccAWSAutoScalingGroup_classicVpcZoneIdentifier (45.56s)
--- PASS: TestAccAWSInstanceDataSource_AzUserData (233.79s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate (54.27s)
--- PASS: TestAccAWSAutoScalingGroup_emptyAvailabilityZones (70.24s)
--- PASS: TestAccAWSInstancesDataSource_basic (193.37s)
--- PASS: TestAccAWSAutoScalingGroup_withPlacementGroup (136.07s)
--- PASS: TestAccAWSInstancesDataSource_tags (193.09s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy (43.69s)
--- PASS: TestAccAWSInstancesDataSource_instance_state_names (193.11s)
--- PASS: TestAccAWSInstanceDataSource_metadataOptions (315.12s)
--- PASS: TestAccAWSAutoScalingGroup_enablingMetrics (193.64s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups (174.10s)
--- PASS: TestAccAWSAutoScalingGroup_LaunchTemplate_IAMInstanceProfile (116.47s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandAllocationStrategy (77.24s)
--- PASS: TestAccAWSAutoScalingGroup_tags (222.66s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_UpdateToZeroOnDemandBaseCapacity (78.10s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandPercentageAboveBaseCapacity (58.09s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotInstancePools (56.71s)
--- PASS: TestAccAWSAutoScalingGroup_launchTemplate_update (156.13s)
--- PASS: TestAccAWSELB_disappears (12.35s)
--- PASS: TestAccAWSELB_basic (14.86s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_LaunchTemplateName (41.95s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_LaunchTemplateSpecification_Version (43.19s)
--- PASS: TestAccAWSELB_fullCharacterRange (18.83s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_InstanceType (48.76s)
--- PASS: TestAccAWSAutoScalingGroup_initialLifecycleHook (230.22s)
--- PASS: TestAccAWSELB_namePrefix (15.87s)
--- PASS: TestAccAWSAutoScalingGroup_suspendingProcesses (256.05s)
--- PASS: TestAccAWSELB_AccessLogs_disabled (29.54s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_OnDemandBaseCapacity (132.47s)
--- PASS: TestAccAWSELB_generatesNameForZeroValue (14.38s)
--- PASS: TestAccAWSAutoScalingGroup_basic (290.63s)
--- PASS: TestAccAWSELB_AccessLogs_enabled (36.16s)
--- PASS: TestAccAWSELB_generatedName (22.00s)
--- PASS: TestAccAWSAutoScalingGroup_TargetGroupArns (246.00s)
--- PASS: TestAccAWSELB_availabilityZones (18.80s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotAllocationStrategy (120.44s)
--- PASS: TestAccAWSAutoScalingGroup_launchTempPartitionNum (77.87s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_InstancesDistribution_SpotMaxPrice (98.01s)
--- PASS: TestResourceAwsElbListenerHash (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotBeginWithHyphen (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCanBeAnEmptyString (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotBeLongerThan32Characters (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotHaveSpecialCharacters (0.00s)
--- PASS: TestResourceAWSELB_validateElbNameCannotEndWithHyphen (0.00s)
--- PASS: TestResourceAWSELB_validateAccessLogsInterval (0.00s)
--- PASS: TestResourceAWSELB_validateHealthCheckTarget (0.00s)
--- PASS: TestAccAWSELBAttachment_drift (75.78s)
--- PASS: TestAccAWSELB_tags (36.59s)
--- PASS: TestFetchRootDevice (0.00s)
    --- PASS: TestFetchRootDevice/device_name_in_mappings (0.00s)
    --- PASS: TestFetchRootDevice/device_name_not_in_mappings (0.00s)
    --- PASS: TestFetchRootDevice/no_images (0.00s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer (317.49s)
--- PASS: TestAccAWSELB_HealthCheck (46.06s)
--- SKIP: TestAccAWSInstance_inEc2Classic (1.15s)
--- PASS: TestAccAWSELBAttachment_basic (103.82s)
--- PASS: TestAccAWSELBUpdate_ConnectionDraining (46.61s)
--- PASS: TestAccAWSELB_Timeout (67.87s)
--- PASS: TestAccAWSAutoScalingGroup_MixedInstancesPolicy_LaunchTemplate_Override_WeightedCapacity (140.71s)
--- PASS: TestAccAWSELBUpdate_Timeout (75.86s)
--- PASS: TestAccAWSAutoScalingGroup_ALB_TargetGroups_ELBCapacity (318.45s)
--- PASS: TestAccAWSAutoScalingGroup_WithLoadBalancer_ToTargetGroup (396.13s)
--- PASS: TestAccAWSInstance_EbsBlockDevice_KmsKeyArn (80.55s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgId (84.32s)
--- PASS: TestAccAWSELB_SecurityGroups (123.12s)
--- PASS: TestAccAwsGlobalAcceleratorListener_basic (123.99s)
--- PASS: TestAccAWSInstance_GP2IopsDevice (82.74s)
--- SKIP: TestAccAWSInstance_outpost (1.64s)
--- PASS: TestAccAWSELB_Listener_SSLCertificateID_IAMServerCertificate (174.36s)
--- PASS: TestAccAWSInstance_GP2WithIopsValue (85.44s)
--- PASS: TestAccAWSInstance_basic (130.25s)
--- PASS: TestAccAWSInstance_ipv6AddressCountAndSingleAddressCausesError (12.67s)
--- PASS: TestAccAWSInstance_noAMIEphemeralDevices (54.31s)
--- PASS: TestAccAwsGlobalAcceleratorListener_update (173.17s)
--- PASS: TestAccAWSInstance_rootInstanceStore (90.15s)
--- PASS: TestAccAWSInstance_inDefaultVpcBySgName (194.89s)
--- PASS: TestAccAWSELB_ConnectionDraining (215.80s)
--- PASS: TestAccAWSInstance_vpc (84.60s)
--- PASS: TestAccAWSELB_listener (238.73s)
--- PASS: TestAccAWSELBUpdate_HealthCheck (238.96s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (76.07s)
--- PASS: TestAccAWSELB_swap_subnets (244.97s)
--- PASS: TestAccAWSInstance_ipv6_supportAddressCountWithIpv4 (65.65s)
--- PASS: TestAccAWSInstance_sourceDestCheck (115.73s)
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (88.41s)
--- PASS: TestAccAWSInstance_NetworkInstanceRemovingAllSecurityGroups (84.29s)
--- PASS: TestAccAWSInstance_userDataBase64 (212.49s)
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (77.93s)
--- PASS: TestAccAWSInstance_privateIP (65.43s)
--- PASS: TestAccAWSInstance_Empty_PrivateIP (66.24s)
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (65.52s)
--- PASS: TestAccAWSInstance_volumeTags (112.86s)
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (95.52s)
--- PASS: TestAccAWSInstance_RootBlockDevice_KmsKeyArn (281.13s)
--- PASS: TestAccAWSInstance_placementGroup (179.82s)
--- PASS: TestAccAWSInstance_withIamInstanceProfile (105.66s)
--- PASS: TestAccAWSInstance_disableApiTermination (216.80s)
--- PASS: TestAccAWSInstance_EbsRootDevice_basic (86.94s)
--- PASS: TestAccAWSInstance_primaryNetworkInterface (67.91s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyType (113.01s)
--- PASS: TestAccAWSELB_InstanceAttaching (423.84s)
--- PASS: TestAccAWSInstance_volumeTagsComputed (193.38s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifySize (133.17s)
--- PASS: TestAccAWSInstance_keyPairCheck (185.22s)
--- PASS: TestAccAWSInstance_EbsRootDevice_ModifyIOPS (123.05s)
--- PASS: TestAccAWSInstance_tags (217.41s)
--- PASS: TestAccAWSInstance_primaryNetworkInterfaceSourceDestCheck (88.30s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifySize (126.65s)
--- PASS: TestAccAWSInstance_addSecurityGroupNetworkInterface (105.53s)
--- PASS: TestAccAWSInstance_addSecondaryInterface (115.50s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPublic (71.67s)
--- PASS: TestAccAWSInstance_associatePublic_explicitPrivate (72.18s)
--- PASS: TestAccAWSInstance_associatePublic_overridePublic (69.04s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPrivate (89.86s)
--- PASS: TestAccAWSInstance_associatePublic_overridePrivate (84.34s)
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (251.01s)
--- PASS: TestAccAWSInstance_creditSpecification_unspecifiedDefaultsToStandard (68.66s)
--- PASS: TestAccAWSInstance_EbsRootDevice_MultipleDynamicEBSBlockDevices (190.91s)
--- PASS: TestAccAWSInstance_changeInstanceType (262.29s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits (88.32s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits (77.07s)
--- PASS: TestAccAWSInstance_getPasswordData_falseToTrue (128.72s)
--- PASS: TestAccAWSInstance_CreditSpecification_UnspecifiedToEmpty_NonBurstable (113.33s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t2 (87.25s)
--- PASS: TestInstanceHostIDSchema (0.00s)
--- PASS: TestInstanceCpuCoreCountSchema (0.00s)
--- PASS: TestInstanceCpuThreadsPerCoreSchema (0.00s)
--- PASS: TestAccAWSInstance_multipleRegions (404.57s)
--- PASS: TestAccAWSInstance_creditSpecification_updateCpuCredits (89.97s)
--- PASS: TestAccAWSInstance_getPasswordData_trueToFalse (145.17s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_standardCpuCredits (72.74s)
--- PASS: TestAccAWSInstance_associatePublic_defaultPublic (178.99s)
--- PASS: TestAccAWSKmsGrant_Basic (30.29s)
--- PASS: TestAccAWSKmsGrant_withRetiringPrincipal (27.98s)
--- PASS: TestAccAWSKmsGrant_bare (27.77s)
--- PASS: TestAccAWSKmsGrant_ARN (28.22s)
--- PASS: TestAccAWSLaunchConfiguration_withBlockDevices (10.02s)
--- PASS: TestAccAWSLaunchConfiguration_basic (16.37s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_updateCpuCredits (97.17s)
--- PASS: TestAccAWSLaunchConfiguration_withInstanceStoreAMI (11.02s)
--- PASS: TestAccAWSLaunchConfiguration_withSpotPrice (10.06s)
--- PASS: TestAccAWSLaunchConfiguration_encryptedRootBlockDevice (12.82s)
--- PASS: TestAccAWSLaunchConfiguration_withVpcClassicLink (13.82s)
--- PASS: TestAccAWSLaunchConfiguration_withEncryption (10.09s)
--- PASS: TestLBListenerARNFromRuleARN (0.00s)
--- PASS: TestAccAWSLaunchConfiguration_RootBlockDevice_VolumeSize (21.41s)
--- PASS: TestAccAWSInstance_UserData_EmptyStringToUnspecified (87.98s)
--- PASS: TestAccAWSInstance_UserData_UnspecifiedToEmptyString (88.28s)
--- PASS: TestAccAWSLaunchConfiguration_updateEbsBlockDevices (16.76s)
--- PASS: TestAccAWSLaunchConfiguration_userData (16.52s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unlimitedCpuCredits (126.24s)
--- PASS: TestAccAWSLaunchConfiguration_ebs_noDevice (20.63s)
--- PASS: TestAccAWSLaunchConfiguration_withIAMProfile (29.87s)
--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (1.11s)
--- PASS: TestAccAWSAutoScalingGroup_LoadBalancers (813.64s)
--- PASS: TestAccAWSInstance_creditSpecification_isNotAppliedToNonBurstable (199.30s)
--- PASS: TestAccAWSInstance_CreditSpecification_Empty_NonBurstable (292.08s)
--- PASS: TestAccAWSInstance_creditSpecification_unknownCpuCredits_t3 (283.85s)
--- PASS: TestAccAWSInstance_disappears (240.49s)
--- PASS: TestAccAWSLBListenerRule_basic (163.15s)
--- PASS: TestAccAWSKmsGrant_disappears (207.11s)
--- PASS: TestAccAWSLBListenerRule_redirect (164.42s)
--- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (20.89s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (1.04s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (170.45s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (179.44s)
--- PASS: TestAccAWSInstance_creditSpecificationT3_unspecifiedDefaultsToUnlimited (320.82s)
--- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (184.56s)
--- PASS: TestAccAWSLBListenerRule_forwardWeighted (198.49s)
--- PASS: TestAccAWSLBListenerRule_cognito (184.53s)
--- PASS: TestAccAWSLBListenerRule_updateFixedResponse (191.67s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (194.51s)
--- PASS: TestAccAWSLBListenerRule_oidc (153.88s)
--- PASS: TestResourceAWSMqBrokerPasswordValidation (0.00s)
--- PASS: TestDiffAwsMqBrokerUsers (0.00s)
--- PASS: TestAccAWSLBListenerRule_priority (228.91s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (158.65s)
--- PASS: TestAccAWSInstance_creditSpecification_unlimitedCpuCredits_t2Tot3Taint (390.91s)
--- PASS: TestAccAWSInstance_hibernation (376.93s)
--- PASS: TestAccAWSInstance_creditSpecification_standardCpuCredits_t2Tot3Taint (405.51s)
--- PASS: TestAccAWSLaunchConfiguration_RootBlockDevice_AmiDisappears (331.92s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (161.95s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (171.93s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader (192.51s)
--- PASS: TestAccAWSLBListenerRule_conditionQueryString (165.93s)
--- PASS: TestAccAWSLBListenerRule_conditionMultiple (153.95s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern (174.32s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader_deprecated (194.62s)
--- PASS: TestAccAWSLBListenerRule_conditionSourceIp (172.98s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMultiple (170.65s)
--- PASS: TestAccAWSLBListenerRule_conditionUpdateMixed (176.87s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_basic (8.52s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_namePrefix (8.65s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_generatedName (8.65s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Description (9.19s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Parameter (13.95s)
--- PASS: TestAccAWSNeptuneClusterParameterGroup_Tags (18.74s)
--- PASS: TestAccAWSNeptuneCluster_basic (130.95s)
--- PASS: TestAccAWSNeptuneCluster_namePrefix (140.49s)
--- PASS: TestAccAWSNeptuneClusterSnapshot_basic (175.85s)
--- PASS: TestAccAWSNeptuneCluster_tags (127.64s)
--- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (151.05s)
--- PASS: TestAccAWSNeptuneCluster_updateIamRoles (127.15s)
--- PASS: TestAccAWSNeptuneCluster_kmsKey (121.48s)
--- PASS: TestAccAWSNeptuneCluster_encrypted (120.78s)
--- PASS: TestAccAWSNeptuneCluster_backupsUpdate (125.73s)
--- PASS: TestAccAWSNeptuneCluster_iamAuth (131.21s)
--- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (141.54s)
--- PASS: TestAccAWSNeptuneParameterGroup_basic (18.51s)
--- PASS: TestAccAWSNeptuneParameterGroup_Description (8.25s)
--- PASS: TestAccAWSNeptuneParameterGroup_Parameter (16.18s)
--- PASS: TestAccAWSNeptuneParameterGroup_Tags (18.21s)
--- PASS: TestAccAWSNeptuneCluster_deleteProtection (152.10s)
--- PASS: TestAccAWSNetworkAclRule_basic (13.50s)
--- PASS: TestAccAWSNetworkAclRule_disappears (10.55s)
--- PASS: TestAccAWSNetworkAclRule_ingressEgressSameNumberDisappears (10.40s)
--- PASS: TestAccAWSNetworkAclRule_disappears_NetworkAcl (10.07s)
--- PASS: TestAccAWSNetworkAclRule_missingParam (6.89s)
--- PASS: TestAccAWSNetworkAclRule_ipv6 (11.14s)
--- PASS: TestAccAWSNetworkAclRule_ipv6ICMP (11.10s)
--- PASS: TestAccAWSNetworkAclRule_ipv6VpcAssignGeneratedIpv6CidrBlockUpdate (18.50s)
--- PASS: TestAccAWSNetworkAclRule_allProtocol (16.70s)
--- PASS: TestAccAWSNetworkAclRule_tcpProtocol (17.16s)
--- PASS: TestAccAWSNetworkAcl_basic (11.29s)
--- PASS: TestAccAWSNetworkAcl_disappears (10.74s)
--- PASS: TestAccAWSNetworkAcl_OnlyIngressRules_basic (13.02s)
--- PASS: TestAccAWSNetworkAcl_Egress_ConfigMode (26.13s)
--- PASS: TestAccAWSNetworkAcl_CaseSensitivityNoChanges (13.28s)
--- PASS: TestAccAWSNetworkAcl_OnlyEgressRules (11.54s)
--- PASS: TestAccAWSNetworkAcl_ipv6Rules (13.00s)
--- PASS: TestAccAWSNetworkAcl_SubnetsDelete (20.10s)
--- PASS: TestAccAWSNetworkAcl_ipv6ICMPRules (10.40s)
--- PASS: TestAccAWSNetworkAcl_ipv6VpcRules (11.06s)
--- PASS: TestAccAWSNetworkAcl_espProtocol (10.51s)
--- PASS: TestAccAWSOpsworksCustomLayer_basic (32.85s)
--- PASS: TestAccAWSNeptuneClusterInstance_generatedName (752.27s)
--- PASS: TestAccAWSProxyProtocolPolicy_basic (14.94s)
--- PASS: TestAccAWSOpsworksCustomLayer_tags (50.92s)
--- PASS: TestAccAWSDBClusterParameterGroup_withApplyMethod (8.74s)
--- PASS: TestAccAWSDBClusterParameterGroup_basic (23.03s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (8.54s)
--- PASS: TestAccAWSNeptuneClusterInstance_withSubnetGroup (781.72s)
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix_Parameter (8.64s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (8.60s)
--- PASS: TestAccAWSDBClusterParameterGroup_disappears (6.75s)
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName_Parameter (8.72s)
--- PASS: TestAccAWSDBClusterParameterGroup_only (8.80s)
--- PASS: TestAccAWSRedshiftParameterGroup_basic (8.22s)
--- PASS: TestAccAWSRedshiftParameterGroup_withParameters (8.30s)
--- SKIP: TestAccAWSRedshiftSecurityGroup_basic (1.00s)
--- SKIP: TestAccAWSRedshiftSecurityGroup_ingressCidr (1.10s)
--- PASS: TestAccAWSRedshiftParameterGroup_withoutParameters (8.01s)
--- SKIP: TestAccAWSRedshiftSecurityGroup_updateIngressCidr (1.00s)
--- PASS: TestCleanRecordName (0.00s)
--- PASS: TestExpandRecordName (0.00s)
--- PASS: TestNormalizeAwsAliasName (0.00s)
--- PASS: TestParseRecordId (0.00s)
--- SKIP: TestAccAWSRedshiftSecurityGroup_ingressSecurityGroup (1.08s)
--- SKIP: TestAccAWSRedshiftSecurityGroup_updateIngressSecurityGroup (1.08s)
--- PASS: TestAccAWSNeptuneClusterInstance_kmsKey (789.33s)
--- PASS: TestAccAWSOpsworksCustomLayer_noVPC (54.18s)
--- PASS: TestAccAWSRedshiftParameterGroup_withTags (18.82s)
--- PASS: TestAccAWSNeptuneClusterInstance_namePrefix (822.90s)
--- PASS: TestAccAWSNeptuneClusterInstance_withaz (850.66s)
--- PASS: TestAccAWSNeptuneClusterInstance_basic (865.39s)
--- PASS: TestAccAWSRoute53Record_disappears (136.47s)
--- PASS: TestAccAWSRoute53Record_basic_fqdn (132.71s)
--- PASS: TestAccAWSRoute53Record_underscored (140.18s)
--- PASS: TestAccAWSRoute53Record_basic (142.55s)
--- PASS: TestAccAWSRoute53Record_txtSupport (137.22s)
--- PASS: TestAccAWSRoute53Record_spfSupport (138.47s)
--- PASS: TestAccAWSRoute53Record_caaSupport (139.32s)
--- PASS: TestAccAWSRoute53Record_disappears_MultipleRecords (168.33s)
--- PASS: TestAccAWSRoute53Record_generatesSuffix (124.92s)
--- PASS: TestAccAWSMqBroker_basic (1126.27s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Enabled (1087.83s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_KmsKeyId (1106.43s)
--- PASS: TestAccAWSRoute53Record_wildcard (187.44s)
--- PASS: TestAccAWSMqBroker_EncryptionOptions_UseAwsOwnedKey_Disabled (1118.11s)
--- PASS: TestAccAWSRoute53Record_weighted_basic (126.77s)
--- PASS: TestAccAWSRoute53Record_failover (131.24s)
--- PASS: TestAccAWSRoute53Record_Alias_Elb (132.63s)
--- PASS: TestAccAWSRoute53Record_Alias_S3 (129.16s)
--- PASS: TestAccAWSRoute53Record_Alias_Uppercase (125.23s)
--- PASS: TestAccAWSRoute53Record_geolocation_basic (126.61s)
--- PASS: TestAccAWSRoute53Record_weighted_to_simple_basic (190.77s)
--- PASS: TestAccAWSMqBroker_updateTags (1160.26s)
--- PASS: TestAccAWSRoute53Record_HealthCheckId_SetIdentifierChange (175.53s)
--- PASS: TestAccAWSMqBroker_disappears (1167.92s)
--- PASS: TestAccAwsRoute53ResolverRule_basic (30.01s)
--- PASS: TestAccAWSRoute53Record_latency_basic (135.44s)
--- PASS: TestAccAwsRoute53ResolverRule_tags (42.38s)
--- PASS: TestAccAwsRoute53ResolverRule_updateName (46.48s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_basic (11.91s)
--- PASS: TestAccAWSRoute53Record_longTXTrecord (129.20s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Empty (1.02s)
--- PASS: TestAccAWSRoute53Record_empty (137.82s)
--- PASS: TestAccAWSRoute53Record_HealthCheckId_TypeChange (183.55s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_removed (17.24s)
--- PASS: TestAccAWSRoute53Record_TypeChange (180.10s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Prefix (18.13s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Empty (1.10s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_SingleTag (17.98s)
--- PASS: TestAccAWSRoute53Record_multivalue_answer_basic (140.49s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_MultipleTags (18.46s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_updateBasic (26.77s)
--- PASS: TestAccAWSRoute53Record_SetIdentifierChange (171.56s)
--- PASS: TestAccAWSRoute53Record_weighted_alias (269.78s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Default (12.69s)
--- PASS: TestAccAWSS3BucketInventory_basic (13.23s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithStorageClassAnalysis_Full (15.05s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSES3 (11.52s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_Remove (18.54s)
--- PASS: TestAccAWSS3BucketMetric_basic (11.72s)
--- PASS: TestAccAWSS3BucketMetric_WithEmptyFilter (11.50s)
--- PASS: TestAccAWSRoute53Record_AliasChange (183.74s)
--- PASS: TestAccAWSS3BucketInventory_encryptWithSSEKMS (22.27s)
--- PASS: TestAccAWSS3BucketAnalyticsConfiguration_WithFilter_PrefixAndTags (38.35s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndMultipleTags (18.34s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefixAndSingleTag (18.94s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterMultipleTags (18.93s)
--- PASS: TestAccAWSS3BucketObject_noNameNoKey (1.42s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterSingleTag (18.73s)
--- PASS: TestAccAWSS3BucketNotification_Queue (15.08s)
--- PASS: TestAccAWSS3BucketMetric_WithFilterPrefix (28.39s)
--- PASS: TestAccAWSS3BucketNotification_Topic (14.62s)
--- PASS: TestAccAwsRoute53ResolverRuleAssociation_basic (141.10s)
--- PASS: TestAccAWSS3BucketObject_empty (11.33s)
--- PASS: TestAccAWSS3BucketNotification_Topic_Multiple (13.88s)
--- PASS: TestAccAWSS3BucketObject_content (11.25s)
--- PASS: TestAccAWSS3BucketObject_etagEncryption (11.47s)
--- PASS: TestAccAWSS3BucketObject_source (12.30s)
--- PASS: TestAccAWSRoute53Record_allowOverwrite (181.39s)
--- PASS: TestAccAWSRoute53Record_NameChange (220.19s)
--- PASS: TestAccAWSS3BucketObject_contentBase64 (12.45s)
--- PASS: TestAccAWSS3BucketObject_withContentCharacteristics (13.36s)
--- PASS: TestAccAWSS3BucketNotification_LambdaFunction (35.44s)
--- PASS: TestAccAWSS3BucketObject_NonVersioned (13.52s)
--- PASS: TestAccAWSS3BucketNotification_LambdaFunction_LambdaFunctionArn_Alias (35.58s)
--- PASS: TestAccAWSS3BucketNotification_update (22.48s)
--- PASS: TestAccAWSS3BucketObject_kms (14.18s)
--- PASS: TestAccAWSS3BucketObject_sse (14.57s)
--- PASS: TestAccAWSS3BucketObject_updates (23.44s)
--- PASS: TestAccAWSS3BucketObject_updateSameFile (22.82s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioning (23.06s)
--- PASS: TestAccAWSS3BucketObject_updatesWithVersioningViaAccessPoint (24.06s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithOn (24.09s)
--- PASS: TestAccAWSS3BucketObject_acl (31.30s)
--- PASS: TestAccAWSMqBroker_updateSecurityGroup (1332.10s)
--- PASS: TestAccAWSS3BucketObject_metadata (30.96s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_disappears (14.19s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_basic (16.49s)
--- PASS: TestAccAWSS3BucketPolicy_basic (18.20s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockLegalHoldStartWithNone (35.24s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_bucketDisappears (11.71s)
--- PASS: TestAccAWSS3BucketObject_tags (42.13s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithNone (35.07s)
--- PASS: TestAccAWSS3BucketPolicy_policyUpdate (29.27s)
--- PASS: TestAccAWSS3BucketObject_tagsLeadingSlash (44.01s)
--- PASS: TestAccAWSS3Bucket_basic (16.42s)
--- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (15.19s)
--- PASS: TestAccAWSS3BucketObject_storageClass (51.94s)
--- PASS: TestAccAWSS3BucketObject_ObjectLockRetentionStartWithSet (43.25s)
--- PASS: TestAccAWSS3Bucket_namePrefix (14.79s)
--- PASS: TestAccAWSS3Bucket_generatedName (15.11s)
--- PASS: TestAccAWSS3MultiBucket_withTags (16.89s)
--- PASS: TestAccAWSS3Bucket_region (15.74s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicAcls (33.77s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_IgnorePublicAcls (34.21s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_RestrictPublicBuckets (33.07s)
--- PASS: TestAccAWSS3BucketPublicAccessBlock_BlockPublicPolicy (35.96s)
--- PASS: TestAccAWSS3Bucket_RequestPayer (25.19s)
--- PASS: TestAccAWSS3Bucket_UpdateAcl (22.42s)
--- PASS: TestAccAWSS3Bucket_acceleration (26.91s)
--- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (41.10s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (13.40s)
--- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (14.89s)
--- PASS: TestAccAWSS3Bucket_AclToGrant (22.48s)
--- PASS: TestAccAWSS3Bucket_GrantToAcl (22.73s)
--- PASS: TestAccAWSS3Bucket_Policy (31.70s)
--- PASS: TestAccAWSS3Bucket_shouldFailNotFound (9.30s)
--- PASS: TestAccAWSS3Bucket_UpdateGrant (33.22s)
--- PASS: TestAccAWSS3Bucket_Website_Simple (31.49s)
--- PASS: TestAccAWSS3Bucket_Cors_Delete (13.16s)
--- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (17.43s)
--- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (24.72s)
--- PASS: TestAccAWSS3Bucket_LifecycleRule_Expiration_EmptyConfigurationBlock (14.93s)
--- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (35.71s)
--- PASS: TestAccAWSS3Bucket_Logging (18.69s)
--- PASS: TestAccAWSS3Bucket_Cors_Update (25.23s)
--- PASS: TestAccAWSS3Bucket_WebsiteRedirect (44.03s)
--- PASS: TestAccAWSS3Bucket_Versioning (32.99s)
--- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (24.62s)
--- PASS: TestAWSS3BucketName (0.00s)
--- PASS: TestBucketRegionalDomainName (0.00s)
--- PASS: TestWebsiteEndpoint (0.00s)
--- PASS: TestAccAWSS3Bucket_forceDestroy (12.13s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (12.49s)
--- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (13.08s)
--- PASS: TestAccAWSS3Bucket_objectLock (22.27s)
--- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (87.76s)
--- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (26.31s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_Base64Binary (11.04s)
--- PASS: TestAccAwsRoute53ResolverRule_forward (240.00s)
--- PASS: TestAccAWSSecurityGroupRule_Ingress_Source_With_Account_Id (16.43s)
--- PASS: TestAccAWSSecurityGroupRule_Ingress_VPC (16.80s)
--- PASS: TestAccAWSSecurityGroupRule_ExpectInvalidTypeError (2.26s)
--- PASS: TestAccAWSSecurityGroupRule_ExpectInvalidCIDR (3.76s)
--- PASS: TestAccAWSSecurityGroupRule_Ingress_Classic (13.26s)
--- PASS: TestAccAWSSecurityGroupRule_Ingress_Protocol (16.99s)
--- PASS: TestAccAWSSecurityGroupRule_Ingress_Ipv6 (16.19s)
--- PASS: TestAccAWSSecurityGroupRule_MultiIngress (14.80s)
--- PASS: TestAccAWSSecurityGroupRule_Egress (15.15s)
--- PASS: TestAccAwsSecretsManagerSecretVersion_VersionStages (27.01s)
--- PASS: TestAccAWSSecurityGroupRule_SelfReference (17.70s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (46.24s)
--- PASS: TestAccAWSS3Bucket_ReplicationWithoutStorageClass (49.64s)
--- PASS: TestAccAWSSecurityGroupRule_Issue5310 (13.28s)
--- PASS: TestAccAWSSecurityGroupRule_IngressDescription (14.99s)
--- PASS: TestAccAWSSecurityGroupRule_SelfSource (17.53s)
--- PASS: TestAccAWSSecurityGroupRule_EgressDescription (15.90s)
--- PASS: TestProtocolStateFunc (0.00s)
--- PASS: TestProtocolForValue (0.00s)
--- PASS: TestResourceAwsSecurityGroupExpandCollapseRules (0.00s)
--- PASS: TestResourceAwsSecurityGroupIPPermGather (0.00s)
--- PASS: TestAccAWSSecurityGroupRule_PartialMatching_basic (24.63s)
--- PASS: TestAccAWSSecurityGroupRule_EgressDescription_updates (23.52s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (78.09s)
--- PASS: TestAccAWSSecurityGroupRule_MultipleRuleSearching_AllProtocolCrash (14.20s)
--- PASS: TestAccAWSSecurityGroupRule_Description_AllPorts (23.45s)
--- PASS: TestAccAWSSecurityGroupRule_PrefixListEgress (30.35s)
--- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AddAccessControlTranslation (78.50s)
--- PASS: TestAccAWSSecurityGroupRule_PartialMatching_Source (33.94s)
--- PASS: TestAccAWSSecurityGroupRule_IngressDescription_updates (27.62s)
--- PASS: TestAccAWSSecurityGroup_allowAll (22.25s)
--- PASS: TestAccAWSSecurityGroupRule_Description_AllPorts_NonZeroPorts (32.00s)
--- PASS: TestAccAWSSecurityGroup_sourceSecurityGroup (37.25s)
--- PASS: TestAccAWSSecurityGroup_basic (32.84s)
--- PASS: TestAccAWSSecurityGroup_namePrefix (21.63s)
--- PASS: TestAccAWSSecurityGroup_ipv6 (23.86s)
--- PASS: TestAccAWSSecurityGroup_IPRangeAndSecurityGroupWithSameRules (37.89s)
--- PASS: TestAccAWSRoute53Record_Alias_VpcEndpoint (533.90s)
--- PASS: TestAccAWSSecurityGroup_ruleGathering (40.06s)
--- PASS: TestAccAWSSecurityGroup_IPRangesWithSameRules (41.59s)
--- PASS: TestAccAWSSecurityGroup_self (17.07s)
--- PASS: TestAccAWSSecurityGroup_ingressConfigMode (52.56s)
--- SKIP: TestAccAWSSecurityGroup_defaultEgressClassic (1.04s)
--- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (125.63s)
--- PASS: TestAccAWSSecurityGroup_vpc (27.71s)
--- PASS: TestAccAWSSecurityGroup_invalidCIDRBlock (2.03s)
--- PASS: TestAccAWSSecurityGroup_generatedName (25.45s)
--- PASS: TestAccAWSSecurityGroup_drift (15.72s)
--- PASS: TestAccAWSS3Bucket_Replication (149.90s)
--- PASS: TestAccAWSSecurityGroup_vpcProtoNumIngress (36.30s)
--- SKIP: TestAccAWSSecurityGroup_ingressWithCidrAndSGsClassic (1.02s)
--- PASS: TestAccAWSSecurityGroup_vpcNegOneIngress (40.81s)
--- PASS: TestAccAWSSecurityGroup_multiIngress (39.11s)
--- PASS: TestAccAWSSecurityGroup_egressConfigMode (82.73s)
--- PASS: TestAccAWSSecurityGroupRule_MultiDescription (100.48s)
--- PASS: TestAccAWSSecurityGroup_defaultEgressVPC (50.91s)
--- PASS: TestAccAWSSecurityGroup_driftComplex (45.06s)
--- PASS: TestAccAWSSecurityGroup_tags (41.60s)
--- PASS: TestAccAWSMqBroker_updateUsers (1619.32s)
--- PASS: TestAccAWSSecurityGroup_ingressWithPrefixList (41.08s)
--- PASS: TestAccAWSSecurityGroup_ipv4andipv6Egress (44.07s)
--- PASS: TestAccAWSSecurityGroup_ruleDescription (82.29s)
--- PASS: TestAccAWSSecurityGroup_egressWithPrefixList (54.04s)
--- PASS: TestAccAWSSecurityGroup_ingressWithCidrAndSGsVPC (56.96s)
--- PASS: TestAccAWSSecurityGroup_change (89.66s)
--- PASS: TestAccAWSSecurityGroup_CIDRandGroups (63.27s)
--- PASS: TestAccAWSSecurityGroup_failWithDiffMismatch (56.73s)
--- PASS: TestAccAWSSecurityGroup_ruleLimitCidrBlockExceededAppend (50.11s)
--- PASS: TestAccAWSSecurityGroup_ruleLimitExceededAppend (60.68s)
--- PASS: TestAccAWSSecurityGroup_rulesDropOnError (41.91s)
--- PASS: TestAccAWSSecurityGroup_ruleLimitExceededAllNew (53.52s)
--- PASS: TestAccAWSSecurityGroupRule_Race (187.87s)
--- PASS: TestAccAwsRoute53ResolverRule_forwardEndpointRecreate (438.39s)
--- PASS: TestAccAWSSecurityGroup_ruleLimitExceededPrepend (71.06s)
--- PASS: TestAccAWSMqBroker_allFieldsDefaultVpc (1808.59s)
--- PASS: TestAccAWSMqBroker_allFieldsCustomVpc (1833.40s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (251.67s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (271.48s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (272.14s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (273.31s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (282.09s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (299.93s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (280.43s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (320.70s)
--- PASS: TestAccAWSSpotFleetRequest_basic (492.35s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (470.95s)
--- PASS: TestAccAWSSpotFleetRequest_tags (503.77s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (480.43s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (497.62s)
--- PASS: TestAccAWSSecurityGroup_forceRevokeRulesFalse (649.32s)
--- SKIP: TestAccAWSSpotFleetRequest_WithInstanceStoreAmi (0.00s)
--- PASS: TestAccAWSSecurityGroup_forceRevokeRulesTrue (654.56s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (290.69s)
--- PASS: TestAccAWSSSMPatchBaseline_basic (14.33s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (543.58s)
--- PASS: TestAccAWSSSMPatchBaseline_disappears (6.45s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (63.59s)
--- PASS: TestAccAWSSSMPatchBaseline_tags (19.36s)
--- PASS: TestAccAWSSSMPatchBaseline_OperatingSystem (13.61s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (333.61s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (270.38s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (340.08s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (138.89s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (588.83s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (150.45s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (299.91s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (461.29s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (414.80s)
--- PASS: TestAccAWSVpcPeeringConnectionOptions_basic (11.98s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (747.21s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_basic (201.30s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (266.37s)
--- PASS: TestAccAWSWafByteMatchSet_basic (21.11s)
--- PASS: TestAccAWSWafByteMatchSet_changeNameForceNew (28.04s)
--- PASS: TestAccAWSWafByteMatchSet_noTuples (14.80s)
--- PASS: TestAccAWSVpcPeeringConnectionOptions_differentRegionSameAccount (39.51s)
--- PASS: TestAccAWSWafByteMatchSet_changeTuples (34.54s)
--- PASS: TestAccAWSWafByteMatchSet_disappears (12.98s)
--- PASS: TestAccAWSWafGeoMatchSet_disappears (11.29s)
--- PASS: TestAccAWSWafGeoMatchSet_basic (18.28s)
--- PASS: TestAccAWSWafGeoMatchSet_changeConstraints (27.50s)
--- PASS: TestAccAWSWafGeoMatchSet_noConstraints (17.22s)
--- PASS: TestAccAWSWafGeoMatchSet_changeNameForceNew (34.42s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (339.99s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSEncrypted (222.31s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (809.71s)
--- PASS: TestDiffWafIpSetDescriptors (0.00s)
    --- PASS: TestDiffWafIpSetDescriptors/0 (0.00s)
    --- PASS: TestDiffWafIpSetDescriptors/1 (0.00s)
    --- PASS: TestDiffWafIpSetDescriptors/2 (0.00s)
--- PASS: TestAccAWSWafIPSet_basic (29.07s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (312.90s)
--- PASS: TestAccAWSWafIPSet_noDescriptors (15.23s)
--- PASS: TestAccAWSWafIPSet_disappears (24.53s)
--- PASS: TestAccAWSWafIPSet_ipv6 (17.17s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_DefaultStorageClass (285.10s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ClientList (300.71s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_GuessMIMETypeEnabled (254.44s)
--- PASS: TestAccAWSWafIPSet_changeNameForceNew (46.09s)
--- PASS: TestAccAWSWafIPSet_changeDescriptors (44.96s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (381.90s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_tags (331.42s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_NFSFileShareDefaults (282.06s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ObjectACL (281.45s)
--- PASS: TestAccAWSWafIPSet_IpSetDescriptors_1000UpdateLimit (76.10s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_KMSKeyArn (300.01s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_ReadOnly (285.18s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_RequesterPays (267.00s)
--- PASS: TestAccAWSStorageGatewayNfsFileShare_Squash (271.33s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (1016.10s)

Unrelated test failures (i.e. non-empty plans, historically failing):

--- FAIL: TestAccAWSInstance_instanceProfileChange (128.78s)
--- FAIL: TestAccAwsSecretsManagerSecretVersion_BasicString (7.08s)
--- FAIL: TestAccAWSS3Bucket_LifecycleBasic (34.12s)
--- FAIL: TestAccAWSInstance_EbsRootDevice_ModifyDeleteOnTermination (119.08s)
--- FAIL: TestAccAWSInstance_EbsRootDevice_ModifyAll (118.62s)
--- FAIL: TestAccAWSLBListenerRule_Action_Order_Recreates (1046.05s)
--- FAIL: TestAccAWSNetworkAcl_SubnetChange (12.31s)
--- FAIL: TestAccAWSNetworkAcl_Subnets (18.96s)
--- FAIL: TestAccAWSInstance_EbsRootDevice_MultipleBlockDevices_ModifyDeleteOnTermination (213.69s)
--- FAIL: TestAccAWSInstance_metadataOptions (49.71s)
--- FAIL: TestAccAWSNetworkAcl_Ingress_ConfigMode (6.80s)
--- FAIL: TestAccAWSNetworkAcl_OnlyIngressRules_update (12.07s)

@ghost ghost added service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cognito service/directconnect Issues and PRs that pertain to the directconnect service. service/organizations Issues and PRs that pertain to the organizations service. labels Jul 9, 2020
@appilon appilon merged commit 95b8432 into master Jul 9, 2020
@appilon appilon deleted the td-remove-set-checks-6 branch July 9, 2020 18:35
@ghost
Copy link

ghost commented Aug 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/directconnect Issues and PRs that pertain to the directconnect service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/kms Issues and PRs that pertain to the kms service. service/mq Issues and PRs that pertain to the mq service. service/neptune Issues and PRs that pertain to the neptune service. service/opsworks Issues and PRs that pertain to the opsworks service. service/organizations Issues and PRs that pertain to the organizations service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/route53 Issues and PRs that pertain to the route53 service. service/s3 Issues and PRs that pertain to the s3 service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/ssm Issues and PRs that pertain to the ssm service. service/storagegateway Issues and PRs that pertain to the storagegateway service. service/waf Issues and PRs that pertain to the waf service. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@appilon @anGie44