Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/wafv2_regex_pattern_set: rewrite typeset checks #14081

Merged
merged 2 commits into from
Jul 7, 2020
Merged

resource/wafv2_regex_pattern_set: rewrite typeset checks #14081

merged 2 commits into from
Jul 7, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jul 7, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/wafv2_regex_pattern_set: rewrite typeset checks

Output from acceptance testing:

--- PASS: TestAccAwsWafv2RegexPatternSet_Minimal (17.84s)
--- PASS: TestAccAwsWafv2RegexPatternSet_Disappears (20.98s)
--- PASS: TestAccAwsWafv2RegexPatternSet_ChangeNameForceNew (29.78s)
--- PASS: TestAccAwsWafv2RegexPatternSet_Basic (31.54s)
--- PASS: TestAccAwsWafv2RegexPatternSet_Tags (43.59s)

@anGie44 anGie44 requested a review from a team July 7, 2020 21:09
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/wafv2 Issues and PRs that pertain to the wafv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 7, 2020
@anGie44 anGie44 requested a review from appilon July 7, 2020 21:09
@anGie44 anGie44 force-pushed the td-remove-set-checks-wafv2-regex branch from 5444539 to 6d1d896 Compare July 7, 2020 21:21
@anGie44 anGie44 merged commit 4e71db8 into td-remove-set-checks-6 Jul 7, 2020
@anGie44 anGie44 deleted the td-remove-set-checks-wafv2-regex branch July 7, 2020 21:58
@ghost
Copy link

ghost commented Aug 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
service/wafv2 Issues and PRs that pertain to the wafv2 service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @appilon