Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template #3131

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Update PR template #3131

merged 4 commits into from
Jun 27, 2023

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jun 19, 2023

What?

Simplifies and add structure to the pull requests template.

Why?

Having checklists is a common practice where we can explicitly ask (or later refer) contributors/maintainers if they have done some essential things like (self-review, linters, and test runs).

@github-actions github-actions bot requested review from imiric and mstoykov June 19, 2023 06:56
@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2023

Codecov Report

Merging #3131 (35ce431) into master (a0c43b8) will increase coverage by 0.03%.
The diff coverage is 71.42%.

❗ Current head 35ce431 differs from pull request most recent head 0bacfff. Consider uploading reports for the commit 0bacfff to get more accurate results

@@            Coverage Diff             @@
##           master    #3131      +/-   ##
==========================================
+ Coverage   73.86%   73.89%   +0.03%     
==========================================
  Files         243      243              
  Lines       18492    18488       -4     
==========================================
+ Hits        13659    13662       +3     
+ Misses       3964     3960       -4     
+ Partials      869      866       -3     
Flag Coverage Δ
ubuntu 73.83% <71.42%> (+0.03%) ⬆️
windows 73.72% <71.42%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cloudapi/config.go 89.47% <ø> (ø)
lib/consts/consts.go 78.57% <ø> (ø)
output/cloud/expv2/metrics_client.go 59.37% <50.00%> (+3.81%) ⬆️
output/cloud/expv2/flush.go 84.61% <100.00%> (ø)
output/cloud/expv2/output.go 86.84% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@codebien codebien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks for taking care of it.

.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
@codebien
Copy link
Contributor

contributors/maintainers if they have done some essential things like (self-review, linters, and test runs).

@olegbespalov can you set clearly the expectations about it? Do you expect us as reviewers will add and check all of them?

@olegbespalov
Copy link
Contributor Author

Hey @codebien .

Do you expect us as reviewers will add and check all of them?

TL;DR: No, I don't expect any reviewers to mark checkbox items.

This checklist is, first of all, for the casual k6's contributors. The idea is to help quickly figure out what is necessary to check even before the code review starts. But I believe it helps also non-casual contributors, even us as maintainers. So the pull request creator should mark the checkboxes, that are applicable to the current case context.

Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
@olegbespalov olegbespalov added this to the v0.46.0 milestone Jun 27, 2023
@olegbespalov olegbespalov merged commit de1aafa into master Jun 27, 2023
20 checks passed
@olegbespalov olegbespalov deleted the chore/update-pr-template branch June 27, 2023 06:04
@olegbespalov olegbespalov mentioned this pull request Jun 28, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants