Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typo #3151

Merged
merged 1 commit into from
Jun 30, 2023
Merged

chore: fix typo #3151

merged 1 commit into from
Jun 30, 2023

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Jun 28, 2023

What?

Fixing the type in the Makefile target of the pull request template.

Why?

The current version doesn't work.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#3131

@olegbespalov olegbespalov self-assigned this Jun 28, 2023
@olegbespalov olegbespalov added this to the v0.46.0 milestone Jun 28, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3151 (fe6d6d2) into master (1df72a0) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head fe6d6d2 differs from pull request most recent head 630b804. Consider uploading reports for the commit 630b804 to get more accurate results

@@            Coverage Diff             @@
##           master    #3151      +/-   ##
==========================================
- Coverage   71.98%   71.98%   -0.01%     
==========================================
  Files         252      252              
  Lines       19405    19405              
==========================================
- Hits        13969    13968       -1     
- Misses       4542     4543       +1     
  Partials      894      894              
Flag Coverage Δ
ubuntu 71.92% <ø> (+0.01%) ⬆️
windows 71.83% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@olegbespalov olegbespalov merged commit 340b0da into master Jun 30, 2023
21 checks passed
@olegbespalov olegbespalov deleted the chore/fix-typo-template branch June 30, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants