Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
olegbespalov committed Jun 19, 2023
1 parent 1d66ed3 commit dafbf69
Showing 1 changed file with 12 additions and 5 deletions.
17 changes: 12 additions & 5 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,28 @@

## Why?

<!-- A short (or detailed) explanation of why these changes are made. -->
<!-- A short (or detailed) explanation of why these changes are made and needed. -->

## Checklist

<!-- Only answer those that apply to your PR: -->
<!--
If you haven't reed the contributing guidelines https://github.com/grafana/k6/blob/master/CONTRIBUTING.md
and code of conduct https://github.com/grafana/k6/blob/master/CODE_OF_CONDUCT.md yet, please do so
-->

- [ ] I have performed a self-review of my code.
- [ ] I have added tests for my changes.
- [ ] I have run linter locally (`make ci-like-lint`) and all checks pass.
- [ ] I have run tests locally (`make test`) and all tests pass.
- [ ] I have commented on my code, particularly in hard-to-understand areas.
- [ ] I have read the [contribution guidelines](https://github.com/grafana/k6/blob/master/CONTRIBUTING.md).
- [ ] I have read the [code of conduct](https://github.com/grafana/k6/blob/master/CODE_OF_CONDUCT.md).
<!-- - [ ] ANYTHING ELSE -->

## Related PR(s)
## Related PR(s)/Issue(s)

<!-- - <https://github.com/grafana/...> -->

<!-- Does it close an issue? -->

<!-- Closes #ISSUE-ID -->

<!-- Thank for your contribution! 🙏🏼 -->

0 comments on commit dafbf69

Please sign in to comment.