feat: add opentelemetry instrumentation #3414

robertlaurin · 2021-03-23T15:21:09Z

Provides instrumentation for https://github.com/open-telemetry/opentelemetry-ruby

Original draft PR feedback here #3185

google-cla · 2021-03-23T15:21:13Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

robertlaurin · 2021-03-23T15:31:00Z

google-apis-core/lib/google/apis/core/http_command.rb

+            'peer.service' => url.host.to_s
+          }
+
+          @opentelemetry_span = Google::Apis::Core::OpenTelemetry.instance.tracer.start_span(url.host.to_s, attributes: attributes)


In general, what's the best practice for naming spans? This just provides the service name. Should we include the method being called?
#3185 (comment)

That's a good question as this isn't always exactly an HTTP span, if the consumers of this instrumentation also include the http client instrumentation these spans will be wrapping the HTTP calls.

For our internal instrumentation we've been using url.host.to_s as the span name.

google-cla · 2021-03-23T15:36:00Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

robertlaurin · 2021-04-26T18:13:16Z

@googlebot I signed it!

robertlaurin

hey @dazuma, there was a bit of a delay getting approval for the CLA.

robertlaurin · 2021-05-27T17:10:29Z

google-apis-core/lib/google/apis/core/opentelemetry.rb

+require 'opentelemetry-api'
+
+module Google
+  module Apis
+    module Core
+      class OpenTelemetry < OpenTelemetry::Instrumentation::Base
+        install { true }
+        present { true }
+      end
+    end
+  end
+end


~~With the addition of the dynamic upgradeable tracer do we still want to make use of this?~~

I've removed this, I think the best version of this remove any dependencies to opentelemetry that is not the api gem.

robertlaurin · 2021-05-28T15:45:31Z

google-apis-core/lib/google/apis/core/http_command.rb

-                  if block_given?
-                    yield result, nil
+            url_host = url.host.to_s
+            OTEL_TRACER.in_span(url_host) do


We have instrumentation for the underlying http lib (http client), so I think it makes sense to not duplicate all the HTTP attributes on this span.

This span also serves the purpose of grouping retired network calls under a common parent span.

genebean · 2022-01-20T15:33:37Z

What's the status of this work? Asking because I am very much interested in putting this to use. Also, is there additional code somewhere that would set attributes like is done for the aws_sdk in https://github.com/open-telemetry/opentelemetry-ruby/blob/f0593e7d97c62b10862c382d14f533dbc49be580/instrumentation/aws_sdk/lib/opentelemetry/instrumentation/aws_sdk/handler.rb#L23-L28 ?

bajajneha27 · 2022-05-18T06:52:39Z

Hi @robertlaurin , I'm so sorry we completely lost track of this. Is it still updated? Would you like to take a look and update the PR accordingly?

bajajneha27 · 2022-06-20T06:24:55Z

Hi @robertlaurin
I'm closing this PR due to inactivity for now but please feel free to reopen it incase you still want to work on this.

google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 23, 2021

robertlaurin mentioned this pull request Mar 23, 2021

[WIP] feat: add opentelemetry instrumentation #3185

Closed

robertlaurin commented Mar 23, 2021

View reviewed changes

feat: add opentelemetry instrumentation

9683dfa

robertlaurin force-pushed the feat-add-opentelemetry branch from b1634b8 to 9683dfa Compare March 23, 2021 15:35

robertlaurin mentioned this pull request Mar 23, 2021

feat: instrument google apis core open-telemetry/opentelemetry-ruby#631

Closed

google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 26, 2021

robertlaurin commented May 27, 2021

View reviewed changes

remove otel instrumentation base dependency

db6abc9

robertlaurin commented May 28, 2021

View reviewed changes

robertlaurin mentioned this pull request Aug 18, 2021

Google API client instrumentation open-telemetry/opentelemetry-ruby-contrib#25

Closed

quartzmo mentioned this pull request Sep 14, 2021

pubsub: Add OpenTelemetry tracing googleapis/google-cloud-ruby#13960

Open

bajajneha27 closed this Jun 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add opentelemetry instrumentation #3414

feat: add opentelemetry instrumentation #3414

robertlaurin commented Mar 23, 2021 •

edited

Loading

google-cla bot commented Mar 23, 2021

robertlaurin Mar 23, 2021

google-cla bot commented Mar 23, 2021

robertlaurin commented Apr 26, 2021

robertlaurin left a comment

robertlaurin May 27, 2021 •

edited

Loading

robertlaurin May 28, 2021

genebean commented Jan 20, 2022

bajajneha27 commented May 18, 2022

bajajneha27 commented Jun 20, 2022

feat: add opentelemetry instrumentation #3414

feat: add opentelemetry instrumentation #3414

Conversation

robertlaurin commented Mar 23, 2021 • edited Loading

google-cla bot commented Mar 23, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

robertlaurin Mar 23, 2021

Choose a reason for hiding this comment

google-cla bot commented Mar 23, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

robertlaurin commented Apr 26, 2021

robertlaurin left a comment

Choose a reason for hiding this comment

robertlaurin May 27, 2021 • edited Loading

Choose a reason for hiding this comment

robertlaurin May 28, 2021

Choose a reason for hiding this comment

genebean commented Jan 20, 2022

bajajneha27 commented May 18, 2022

bajajneha27 commented Jun 20, 2022

robertlaurin commented Mar 23, 2021 •

edited

Loading

robertlaurin May 27, 2021 •

edited

Loading