Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pubsub: Add OpenTelemetry tracing #13960

Open
quartzmo opened this issue Sep 9, 2021 · 1 comment
Open

pubsub: Add OpenTelemetry tracing #13960

quartzmo opened this issue Sep 9, 2021 · 1 comment
Assignees
@dazuma
Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@quartzmo
Copy link
Member

quartzmo commented Sep 9, 2021 •
edited
Loading

OpenTelemetry should be added to trace a message throughout its lifecycle. It should be an optional dependency that creates a trace that tracks a message from when it is published to when it is received by a subscriber. OpenTelemetry tracing should not interfere with any underlying client functions.

See googleapis/google-cloud-go/pull/5034.

See also some older work: Python PR and Node publisher impl for the state of implementations in other clients. At this time, none is complete to my knowledge.

The opentelemetry-ruby opentelemetry-api gem is 1.0.0.rc3, stable enough to begin work.

See also the opentelemetry-specification messaging samples and w3.org spec.
@quartzmo quartzmo self-assigned this Sep 9, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Sep 9, 2021
@quartzmo quartzmo added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 9, 2021
@quartzmo
Copy link
Member Author

See also googleapis/google-api-ruby-client#3414 for an example Ruby implementation.

quartzmo added a commit to quartzmo/google-cloud-ruby that referenced this issue Dec 23, 2021
@quartzmo
feat(pubsub): Add opentelemetry trace support
c6c31a5 
closes: googleapis#13960
@quartzmo quartzmo mentioned this issue Dec 23, 2021
Closed
@quartzmo quartzmo assigned dazuma and unassigned quartzmo Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dazuma dazuma

Labels
api: pubsub Issues related to the Pub/Sub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(pubsub): Add Open Telemetry trace support quartzmo/google-cloud-ruby
2 participants
@dazuma @quartzmo