Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamically upgrade global tracer provider #708

Merged
merged 7 commits into from
Apr 19, 2021
Merged

fix: dynamically upgrade global tracer provider #708

merged 7 commits into from
Apr 19, 2021

Conversation

fbogsany
Copy link
Contributor

@fbogsany fbogsany commented Apr 9, 2021

Fixes #706

@fbogsany fbogsany mentioned this pull request Apr 12, 2021
Closed
6 tasks
mwear
mwear reviewed Apr 13, 2021
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. However, I am suspicious about the test failures as they appear to be related and vary with Ruby version.

@fbogsany fbogsany merged commit 3847efc into main Apr 19, 2021
@fbogsany fbogsany deleted the proxy-tracer branch April 19, 2021 15:09
@robertlaurin robertlaurin mentioned this pull request May 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwear mwear mwear left review comments

@robertlaurin robertlaurin robertlaurin approved these changes

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Tracer auto-promotion to SDK Tracer
3 participants
@fbogsany @mwear @robertlaurin