Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make _BackdropScaffoldState public and document it #31

Closed
8 tasks done
daadu opened this issue Jun 3, 2020 · 2 comments · Fixed by #36
Closed
8 tasks done

make _BackdropScaffoldState public and document it #31

daadu opened this issue Jun 3, 2020 · 2 comments · Fixed by #36
Assignees
@WieFel
Labels
documentation Document change or request enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v1.0

Comments

@daadu
Copy link
Member

daadu commented Jun 3, 2020 •
edited by WieFel
Loading

  • make _BackdropScaffoldState public
  • members to be documented
    • AnimationController get controller
    • bool get isBackLayerConcealed
    • bool get isBackLayerRevealed
    • void fling()
    • void revealBackLayer()
    • void concealBackLayer()
@daadu daadu added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 3, 2020
@daadu daadu added this to the v1.0 milestone Jun 3, 2020
@daadu daadu added the documentation Document change or request label Jun 3, 2020
@daadu
Copy link
Member Author

daadu commented Jun 4, 2020

I would suggest we also use the term "reveal" and "conceal" every where in documentation where ever we have mentioned "backLayer is visible" or "frontLayer is visible"

@daadu daadu changed the title Document public members of _BackdropScaffoldState make _BackdropScaffoldState public and document it Jun 4, 2020
@daadu daadu changed the title make _BackdropScaffoldState public and document it make _BackdropScaffoldState public and document it Jun 4, 2020
@daadu
Copy link
Member Author

daadu commented Jun 4, 2020

This should be worked on after #32 is merged with master

@daadu daadu added the waiting Waiting for another PR to be merged label Jun 4, 2020
@daadu daadu mentioned this issue Jun 6, 2020
Merged
@daadu daadu removed the waiting Waiting for another PR to be merged label Jun 6, 2020
@daadu daadu closed this as completed in #36 Jun 6, 2020
daadu added a commit that referenced this issue Jun 6, 2020
@daadu
Merge pull request #36 from fluttercommunity/feature/#31-doc-Backdrop…
40eae11 
…ScaffoldState

refactor - making `BackdropScaffoldState` class public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WieFel WieFel

Labels
documentation Document change or request enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

refactor - making BackdropScaffoldState class public fluttercommunity/backdrop
2 participants
@daadu @WieFel