Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backdrop.dart #32

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Refactor backdrop.dart #32

merged 1 commit into from
Jun 6, 2020

Conversation

daadu
Copy link
Member

@daadu daadu commented Jun 4, 2020

Closes #25

@daadu
Copy link
Member Author

daadu commented Jun 4, 2020

Waiting for #26 to merge with master before this major refactor.

@daadu daadu self-assigned this Jun 4, 2020
@daadu daadu added this to the v1.0 milestone Jun 4, 2020
@daadu daadu added waiting Waiting for another PR to be merged and removed waiting Waiting for another PR to be merged labels Jun 4, 2020
@daadu daadu closed this Jun 5, 2020
@daadu daadu reopened this Jun 5, 2020
@daadu daadu requested a review from WieFel June 5, 2020 10:19
@daadu daadu changed the title WIP: Refactor backdrop.dart Refactor backdrop.dart Jun 6, 2020
@daadu
Copy link
Member Author

daadu commented Jun 6, 2020

@WieFel Should we go ahead with this?

Copy link
Collaborator

@WieFel WieFel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, been busy. LGTM!

@daadu daadu merged commit 04c4ba5 into master Jun 6, 2020
@daadu daadu deleted the feature/#25-refactor branch June 6, 2020 08:44
@daadu
Copy link
Member Author

daadu commented Jun 6, 2020

This feature has landed in v0.4.0 in pub.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitting widgets to different files
2 participants