Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor - making BackdropScaffoldState class public #36

Merged
merged 3 commits into from
Jun 6, 2020

Conversation

daadu
Copy link
Member

@daadu daadu commented Jun 6, 2020

Closes #31

@daadu daadu added this to the v1.0 milestone Jun 6, 2020
@daadu daadu added the documentation Document change or request label Jun 6, 2020
@daadu
Copy link
Member Author

daadu commented Jun 6, 2020

@WieFel I have made the class public. Request you to complete the documentation as discussed in #31

@daadu daadu self-assigned this Jun 6, 2020
@WieFel
Copy link
Collaborator

WieFel commented Jun 6, 2020

Documented the members mentioned in #31.

scaffoldKey is still public. But I think it could be made private?

Also there is getPanelAnimation() which is public. Not sure whether this also should be made private?
@daadu

@daadu
Copy link
Member Author

daadu commented Jun 6, 2020

scaffoldKey is still public. But I think it could be made private?

scaffoldKey is public if some user want to access the underlying scaffold to - show snackbar or somethings like that. It can be done by using Backdrop.of(context).scaffoldKey.currentState.showSnackBar(...)

Also there is getPanelAnimation() which is public. Not sure whether this also should be made private?

I agree, this should be made private

@WieFel Do necessary changes.

@WieFel
Copy link
Collaborator

WieFel commented Jun 6, 2020

@daadu done!

@daadu daadu changed the title WIP: refactor - making BackdropScaffoldState class public refactor - making BackdropScaffoldState class public Jun 6, 2020
@daadu daadu merged commit 40eae11 into master Jun 6, 2020
@daadu daadu deleted the feature/#31-doc-BackdropScaffoldState branch June 6, 2020 15:06
@daadu
Copy link
Member Author

daadu commented Jun 6, 2020

This feature has landed in v0.4.1 on pub.dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Document change or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make _BackdropScaffoldState public and document it
2 participants