Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explanation for adding everything as dependencies to docs #6082

Merged
merged 4 commits into from
Apr 3, 2019
Merged

Add explanation for adding everything as dependencies to docs #6082

merged 4 commits into from
Apr 3, 2019

Conversation

attaradev
Copy link
Contributor

add the reason for adding packages as dependencies

@attaradev
Update available-scripts.md
1d8d794 
add the reason for adding packages as dependencies
@attaradev attaradev changed the title Add reason for adding everything as dependencies to docs #5885 Add reason for adding everything as dependencies to docs Dec 22, 2018
@attaradev
Copy link
Contributor Author

@iansu what do you think?

@attaradev attaradev mentioned this pull request Dec 22, 2018
Closed
@attaradev attaradev changed the title Add reason for adding everything as dependencies to docs Add explanation for adding everything as dependencies to docs Dec 22, 2018
@Timer Timer mentioned this pull request Dec 23, 2018
Closed
@attaradev
Copy link
Contributor Author

@Timer what is your thought?

@ianschmitz ianschmitz added this to the 2.1.4 milestone Jan 7, 2019
@ianschmitz ianschmitz modified the milestones: 2.1.4, 2.1.5 Feb 10, 2019
@iansu iansu modified the milestones: 2.1.6, 2.1.x Mar 6, 2019
@attaradev
Copy link
Contributor Author

@ianschmitz what is your thought?

@iansu iansu modified the milestones: 2.1.x, 3.0 Mar 10, 2019
amyrlam
amyrlam approved these changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small tweak, looks good, thanks for the PR! 👍

iansu
iansu suggested changes Apr 3, 2019
View reviewed changes
docusaurus/docs/available-scripts.md Outdated Show resolved Hide resolved
docusaurus/docs/available-scripts.md Outdated Show resolved Hide resolved
docusaurus/docs/available-scripts.md Outdated Show resolved Hide resolved
@amyrlam amyrlam requested a review from iansu April 3, 2019 19:27
@iansu iansu merged commit e630238 into facebook:master Apr 3, 2019
@lock lock bot locked and limited conversation to collaborators Apr 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyrlam amyrlam amyrlam approved these changes

@iansu iansu Awaiting requested review from iansu

Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@attaradev @iansu @amyrlam @ianschmitz @facebook-github-bot