Add explanation of why we install everything as a dependency to the docs #5885
Conversation
This is to solve issue #5805
Added the link to more elaborate resource
|
I don't think this is the right location for this. It doesn't just apply to ejected apps. I think this page might be a better place for it: https://facebook.github.io/create-react-app/docs/installing-a-dependency Rather than just linking to the Stack Overflow answer I would like to incorporate the answer into the page. Maybe we add a section to the end of that page that explains why we install everything as a dependency. |
|
Alright. I will work on it @iansu |
|
@iansu When you install a dev dependency after using create react app puts it in devDependency. I think the issue is more with the |
|
It's true that none of these packages end up in |
docusaurus/docs/available-scripts.md
Outdated
| @@ -30,6 +30,8 @@ See the section about [deployment](deployment.md) for more information. | |||
|
|
|||
| If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. | |||
|
|
|||
| Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own. | |||
| Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project as dependencies in `package.json`. You have full control over them and can always rearrange `package.json` as you deem reasonable. You can read [more here](https://stackoverflow.com/questions/44868453/create-react-app-install-devdepencies-in-dependencies-section) | |||
There was a problem hiding this comment.
Maybe add a new paragraph after "...as dependencies in package.json" where we explain why they are installed as dependencies instead of dev dependencies.
There was a problem hiding this comment.
@iansu Kindly review this one and let me know what you think
Update the reason and remove the link to stackoverflow
update to reflect consistency in language choice
docusaurus/docs/available-scripts.md
Outdated
| @@ -30,6 +30,8 @@ See the section about [deployment](deployment.md) for more information. | |||
|
|
|||
| If you aren’t satisfied with the build tool and configuration choices, you can `eject` at any time. This command will remove the single build dependency from your project. | |||
|
|
|||
| Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project so you have full control over them. All of the commands except `eject` will still work, but they will point to the copied scripts so you can tweak them. At this point you’re on your own. | |||
| Instead, it will copy all the configuration files and the transitive dependencies (Webpack, Babel, ESLint, etc) right into your project as dependencies in `package.json`. You have full control over them and can always rearrange `package.json` as you deem reasonable. You can read [more here](https://stackoverflow.com/questions/44868453/create-react-app-install-devdepencies-in-dependencies-section) | |||
There was a problem hiding this comment.
@iansu Trust you are good...
add explanation
|
Deploy preview for gallant-davinci-8f9bd9 failed. Built with commit 4be39ea https://app.netlify.com/sites/gallant-davinci-8f9bd9/deploys/5c037024ec8a896b7b61a8c2 |
formatting
|
@iansu Why is the build failing? |
|
#6082 The updated edit to the docs |
|
I am closing this pr. Kindly check #6082 for the updated pr. |
This solves issue #5805 @iansu and @Timer
Kindly review my suggested solution
Thanks