Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation of why we install everything as a dependency to the docs #5805

Closed
iansu opened this issue Nov 14, 2018 · 6 comments
Closed

Comments

@iansu
Copy link
Contributor

iansu commented Nov 14, 2018

At least once a week we get an issue or a PR about the examples in the docs where we install things like prettier or typescript as dependencies instead of dev dependencies. We should add an explanation of this somewhere in the docs. Then we can reference that when we provide examples of installing dependencies. We could also link to that if/when people submit issues or PRs.

@attaradev
Copy link
Contributor

Can you please throw more light on what exactly you expect? @iansu

@iansu
Copy link
Contributor Author

iansu commented Nov 22, 2018

Here's a Stack Overflow post where @gaearon explains this: https://stackoverflow.com/questions/44868453/create-react-app-install-devdepencies-in-dependencies-section

The goal is to add an explanation similar to this to the docs. I'm not about where this should go in the docs so you'll have to look around and find a suitable place.

@attaradev
Copy link
Contributor

Thanks @iansu
I would like to take it up then

@attaradev
Copy link
Contributor

@iansu I have edited the docs. Kindly check and let me know what you think.

@stale
Copy link

stale bot commented Dec 23, 2018

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 23, 2018
@Timer
Copy link
Contributor

Timer commented Dec 23, 2018

Closing in favor of PR #6082. Thanks!

@Timer Timer closed this as completed Dec 23, 2018
@lock lock bot locked and limited conversation to collaborators Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants