[7.17] [Dashboard] Fix blank panel save and display issue. (#120815) #121661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added special case to panel comparison. * Fixed panel title behaviour when linking/unlinking to/from the library. * Added panel title test suite. * Made the injection of the 'savedSearchId' key conditional on if it is defined when unlinking. * Adjusted use of 'setValue()' based on feedback from @dmlemeshko * Refractor test suite. * Improved code for removal of title on library link. # Conflicts: # src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
HistoryTo update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.17: