[maps] remove tile_map, region_map, and maps_legacy plugins #105326

nreese · 2021-07-12T20:34:58Z

This PR removes tile_map, region_map, and maps_legacy plugins. Maps plugin is updated to register tile_map and region_map visualizations that render using MapEmbeddable. To edit tile_map and region_map visualizations, users will need to save then as Maps saved objects and then replace panels in Dashboards or Canvases.

elasticmachine · 2021-07-12T20:35:00Z

Pinging @elastic/kibana-gis (Team:Geo)

kibanamachine · 2021-07-12T20:42:43Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 1bb6c05
Storybooks not built yet
This comment will update when the build is complete

Failed CI Steps

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

nreese · 2021-07-13T20:15:39Z

@elasticmachine merge upstream

spalger · 2021-07-14T19:31:04Z

Please consider using Draft PRs when you're not ready for review, it prevents pinging automatic reviewers until you explicitly set it ready for review. Unsubscribing for now so please ping when you're ready.

kibanamachine · 2021-07-14T22:27:25Z

⏳ Build in-progress, with failures

continuous-integration/kibana-ci/pull-request
Commit: 4649f51
Storybooks not built yet
This comment will update when the build is complete

Failed CI Steps

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ThomThomson

Code only review - looked through the functional test removals for Presentation team, and they are only related to the legacy maps removed by this PR. Left a suggestion for how to add more coverage, but that can be done separately.

LGTM!

ThomThomson · 2021-08-09T16:24:10Z

test/functional/apps/dashboard/embeddable_library.ts

@@ -68,44 +68,5 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
      );
      expect(libraryActionExists).to.be(true);
    });
-
-    it('unlink map panel from embeddable library', async () => {


Not necessarily related to this PR - because these tests are associated with the legacy maps, but it seems like there isn't any functional test coverage for linking / unlinking maps panels from the embeddable. Perhaps tests similar to these should be added to x-pack/test/functional/apps/dashboard/dashboard_maps_by_value.ts

…e_tile_map

thomasneirynck

Wow

See initial inline comments.

We can also remove

kibana/x-pack/plugins/maps/public/maps_vis_type_alias.ts

Lines 28 to 30 in d2e2209

    
           if (!showMapVisualizationTypes) { 
        
             visualizations.hideTypes(['region_map', 'tile_map']); 
        
           }

package.json

x-pack/plugins/maps/public/embeddable/map_component.tsx

x-pack/plugins/maps/public/legacy_visualizations/region_map/region_map_fn.ts

nreese · 2021-08-12T16:23:42Z

We can also remove

I am saving the removal of xpack.maps.showMapVisualizationTypes for its own PR - #105979

nreese · 2021-08-13T14:57:58Z

@elasticmachine merge upstream

thomasneirynck

fantastic.

thx for introducing MapComponent too. It should make future use of the MapsEmbeddable much easier.

kibanamachine · 2021-08-18T17:26:39Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`maps`	807	828	+21
`mapsLegacy`	49	-	-49
`regionMap`	30	-	-30
`tileMap`	40	-	-40
total			-98

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`maps`	3.2MB	3.2MB	+1.4KB
`mapsLegacy`	278.0KB	-	-278.0KB
`regionMap`	273.8KB	-	-273.8KB
`tileMap`	277.9KB	-	-277.9KB
total			-828.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`maps`	66.0KB	79.3KB	+13.3KB
`mapsLegacy`	62.8KB	-	-62.8KB
`regionMap`	18.2KB	-	-18.2KB
`tileMap`	16.5KB	-	-16.5KB
total			-84.2KB

Unknown metric groups

API count

id	before	after	diff
`maps`	215	219	+4

API count missing comments

id	before	after	diff
`maps`	214	218	+4

async chunk count

id	before	after	diff
`mapsLegacy`	1	-	-1
`regionMap`	3	-	-3
`tileMap`	4	-	-4
total			-8

References to deprecated APIs

id	before	after	diff
`maps`	655	685	+30

History

💚 Build #145290 succeeded 568f1ee
💚 Build #145270 succeeded f935259
💚 Build #145254 succeeded 8aea3fa
💚 Build #144445 succeeded 2dc9a5e
💚 Build #143777 succeeded 89350e9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-08-20T18:57:06Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 105326 or prevent reminders by adding the backport:skip label.

nreese · 2021-08-20T19:01:35Z

Friendly reminder: Looks like this PR hasn’t been backported yet.

No backport required for this change, 8.0 only

Fixes #154375 ### background #105326 replaced tile_map visualization implementation with a new implementation that is a wrapper around MapEmbeddable. #152952 removed geohash_grid aggregation. This causes a regression where existing tile_map visualizations no longer work. Even though geohash_grid aggregation is no longer used, the AggType is still needed so that new tile_map visualization wrapper can access aggregation configuration state. This PR adds back geohash_grid AggType in `legacyAggs` for this purpose. PR also adds a functional test to better prevent regressions with tile_map ### Test * install web logs sample data * install legacy tile_map saved objects from ``` {"attributes":{"fieldFormatMap":"{\"hour_of_day\":{}}","runtimeFieldMap":"{\"hour_of_day\":{\"type\":\"long\",\"script\":{\"source\":\"emit(doc['timestamp'].value.getHour());\"}}}","timeFieldName":"timestamp","title":"kibana_sample_data_logs"},"coreMigrationVersion":"7.17.5","id":"90943e30-9a47-11e8-b64d-95841ca0b247","migrationVersion":{"index-pattern":"7.11.0"},"references":[],"type":"index-pattern","updated_at":"2022-08-17T20:25:52.585Z","version":"WzEzMDQsMV0="} {"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"language\":\"kuery\",\"query\":\"\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"title":"region_map","uiStateJSON":"{}","version":1,"visState":"{\"aggs\":[{\"enabled\":true,\"id\":\"1\",\"params\":{},\"schema\":\"metric\",\"type\":\"count\"},{\"enabled\":true,\"id\":\"2\",\"params\":{\"field\":\"geo.dest\",\"missingBucket\":false,\"missingBucketLabel\":\"Missing\",\"order\":\"desc\",\"orderBy\":\"1\",\"otherBucket\":false,\"otherBucketLabel\":\"Other\",\"size\":5},\"schema\":\"segment\",\"type\":\"terms\"}],\"params\":{\"addTooltip\":true,\"colorSchema\":\"Yellow to Red\",\"emsHotLink\":\"https://maps.elastic.co/v7.16?locale=en#file/world_countries\",\"isDisplayWarning\":true,\"legendPosition\":\"bottomright\",\"mapCenter\":[0,0],\"mapZoom\":2,\"outlineWeight\":1,\"selectedJoinField\":{\"description\":\"ISO 3166-1 alpha-2 code\",\"name\":\"iso2\",\"type\":\"id\"},\"selectedLayer\":{\"attribution\":\"<a rel=\\\"noreferrer noopener\\\" href=\\\"http://www.naturalearthdata.com/about/terms-of-use\\\">Made with NaturalEarth</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.openstreetmap.org/copyright\\\">OpenStreetMap contributors</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.elastic.co/elastic-maps-service\\\">Elastic Maps Service</a>\",\"created_at\":\"2020-10-28T16:16:08.720286\",\"fields\":[{\"description\":\"ISO 3166-1 alpha-2 code\",\"name\":\"iso2\",\"type\":\"id\"},{\"description\":\"ISO 3166-1 alpha-3 code\",\"name\":\"iso3\",\"type\":\"id\"},{\"description\":\"ISO 3166-1 numeric code\",\"name\":\"iso_numeric\",\"type\":\"id\"},{\"description\":\"name\",\"name\":\"name\",\"type\":\"property\"}],\"format\":\"topojson\",\"id\":\"world_countries\",\"isEMS\":true,\"layerId\":\"elastic_maps_service.World Countries\",\"meta\":{\"feature_collection_path\":\"data\"},\"name\":\"World Countries\",\"origin\":\"elastic_maps_service\"},\"showAllShapes\":true,\"wms\":{\"enabled\":false,\"options\":{\"attribution\":\"\",\"format\":\"image/png\",\"layers\":\"\",\"styles\":\"\",\"transparent\":true,\"version\":\"\"},\"selectedTmsLayer\":{\"attribution\":\"<a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.openstreetmap.org/copyright\\\">OpenStreetMap contributors</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://openmaptiles.org\\\">OpenMapTiles</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.elastic.co/elastic-maps-service\\\">Elastic Maps Service</a>\",\"id\":\"road_map\",\"maxZoom\":20,\"minZoom\":0,\"origin\":\"elastic_maps_service\"},\"url\":\"\"}},\"title\":\"region_map\",\"type\":\"region_map\"}"},"coreMigrationVersion":"7.17.5","id":"64a5b9f0-1e6b-11ed-833b-a105e9534fa9","migrationVersion":{"visualization":"7.17.0"},"references":[{"id":"90943e30-9a47-11e8-b64d-95841ca0b247","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"visualization","updated_at":"2022-08-17T20:30:50.288Z","version":"WzE0MDIsMV0="} {"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"\",\"language\":\"kuery\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"title":"tile_map","uiStateJSON":"{\"mapZoom\":2,\"mapCenter\":[13.64385981167601,-135.97675761558068]}","version":1,"visState":"{\"title\":\"tile_map\",\"type\":\"tile_map\",\"aggs\":[{\"id\":\"1\",\"enabled\":true,\"type\":\"count\",\"params\":{},\"schema\":\"metric\"},{\"id\":\"2\",\"enabled\":true,\"type\":\"geohash_grid\",\"params\":{\"field\":\"geo.coordinates\",\"autoPrecision\":true,\"precision\":2,\"useGeocentroid\":true,\"isFilteredByCollar\":true},\"schema\":\"segment\"}],\"params\":{\"colorSchema\":\"Yellow to Red\",\"mapType\":\"Scaled Circle Markers\",\"isDesaturated\":true,\"addTooltip\":true,\"heatClusterSize\":1.5,\"legendPosition\":\"bottomright\",\"mapZoom\":2,\"mapCenter\":[0,0],\"wms\":{\"enabled\":false,\"url\":\"\",\"options\":{\"version\":\"\",\"layers\":\"\",\"format\":\"image/png\",\"transparent\":true,\"attribution\":\"\",\"styles\":\"\"},\"selectedTmsLayer\":{\"origin\":\"elastic_maps_service\",\"id\":\"road_map\",\"minZoom\":0,\"maxZoom\":20,\"attribution\":\"<a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.openstreetmap.org/copyright\\\">OpenStreetMap contributors</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://openmaptiles.org\\\">OpenMapTiles</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.elastic.co/elastic-maps-service\\\">Elastic Maps Service</a>\"}}}}"},"coreMigrationVersion":"7.17.5","id":"4b073190-1e6b-11ed-833b-a105e9534fa9","migrationVersion":{"visualization":"7.17.0"},"references":[{"id":"90943e30-9a47-11e8-b64d-95841ca0b247","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"visualization","updated_at":"2022-08-17T20:29:28.769Z","version":"WzEzNDksMV0="} {"attributes":{"description":"","hits":0,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"\",\"language\":\"kuery\"},\"filter\":[]}"},"optionsJSON":"{\"useMargins\":true,\"syncColors\":false,\"hidePanelTitles\":false}","panelsJSON":"[{\"version\":\"7.17.5\",\"type\":\"visualization\",\"gridData\":{\"x\":24,\"y\":0,\"w\":24,\"h\":15,\"i\":\"ad02c99b-8bae-42e0-8a43-d27762f1e607\"},\"panelIndex\":\"ad02c99b-8bae-42e0-8a43-d27762f1e607\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_ad02c99b-8bae-42e0-8a43-d27762f1e607\"},{\"version\":\"7.17.5\",\"type\":\"visualization\",\"gridData\":{\"x\":0,\"y\":0,\"w\":24,\"h\":15,\"i\":\"8412ffc8-b94c-4bbd-aa55-fa670f3fb4ee\"},\"panelIndex\":\"8412ffc8-b94c-4bbd-aa55-fa670f3fb4ee\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_8412ffc8-b94c-4bbd-aa55-fa670f3fb4ee\"}]","timeRestore":false,"title":"dash with legacy map visualizations","version":1},"coreMigrationVersion":"7.17.5","id":"97437d70-1e6b-11ed-833b-a105e9534fa9","migrationVersion":{"dashboard":"7.17.3"},"references":[{"id":"64a5b9f0-1e6b-11ed-833b-a105e9534fa9","name":"ad02c99b-8bae-42e0-8a43-d27762f1e607:panel_ad02c99b-8bae-42e0-8a43-d27762f1e607","type":"visualization"},{"id":"4b073190-1e6b-11ed-833b-a105e9534fa9","name":"8412ffc8-b94c-4bbd-aa55-fa670f3fb4ee:panel_8412ffc8-b94c-4bbd-aa55-fa670f3fb4ee","type":"visualization"}],"type":"dashboard","updated_at":"2022-08-17T20:31:36.656Z","version":"WzE0MzEsMV0="} {"excludedObjects":[],"excludedObjectsCount":0,"exportedCount":4,"missingRefCount":0,"missingReferences":[]} ``` * Open dashboard and verify tile_map renders --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

Fixes elastic#154375 ### background elastic#105326 replaced tile_map visualization implementation with a new implementation that is a wrapper around MapEmbeddable. elastic#152952 removed geohash_grid aggregation. This causes a regression where existing tile_map visualizations no longer work. Even though geohash_grid aggregation is no longer used, the AggType is still needed so that new tile_map visualization wrapper can access aggregation configuration state. This PR adds back geohash_grid AggType in `legacyAggs` for this purpose. PR also adds a functional test to better prevent regressions with tile_map ### Test * install web logs sample data * install legacy tile_map saved objects from ``` {"attributes":{"fieldFormatMap":"{\"hour_of_day\":{}}","runtimeFieldMap":"{\"hour_of_day\":{\"type\":\"long\",\"script\":{\"source\":\"emit(doc['timestamp'].value.getHour());\"}}}","timeFieldName":"timestamp","title":"kibana_sample_data_logs"},"coreMigrationVersion":"7.17.5","id":"90943e30-9a47-11e8-b64d-95841ca0b247","migrationVersion":{"index-pattern":"7.11.0"},"references":[],"type":"index-pattern","updated_at":"2022-08-17T20:25:52.585Z","version":"WzEzMDQsMV0="} {"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"language\":\"kuery\",\"query\":\"\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"title":"region_map","uiStateJSON":"{}","version":1,"visState":"{\"aggs\":[{\"enabled\":true,\"id\":\"1\",\"params\":{},\"schema\":\"metric\",\"type\":\"count\"},{\"enabled\":true,\"id\":\"2\",\"params\":{\"field\":\"geo.dest\",\"missingBucket\":false,\"missingBucketLabel\":\"Missing\",\"order\":\"desc\",\"orderBy\":\"1\",\"otherBucket\":false,\"otherBucketLabel\":\"Other\",\"size\":5},\"schema\":\"segment\",\"type\":\"terms\"}],\"params\":{\"addTooltip\":true,\"colorSchema\":\"Yellow to Red\",\"emsHotLink\":\"https://maps.elastic.co/v7.16?locale=en#file/world_countries\",\"isDisplayWarning\":true,\"legendPosition\":\"bottomright\",\"mapCenter\":[0,0],\"mapZoom\":2,\"outlineWeight\":1,\"selectedJoinField\":{\"description\":\"ISO 3166-1 alpha-2 code\",\"name\":\"iso2\",\"type\":\"id\"},\"selectedLayer\":{\"attribution\":\"<a rel=\\\"noreferrer noopener\\\" href=\\\"http://www.naturalearthdata.com/about/terms-of-use\\\">Made with NaturalEarth</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.openstreetmap.org/copyright\\\">OpenStreetMap contributors</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.elastic.co/elastic-maps-service\\\">Elastic Maps Service</a>\",\"created_at\":\"2020-10-28T16:16:08.720286\",\"fields\":[{\"description\":\"ISO 3166-1 alpha-2 code\",\"name\":\"iso2\",\"type\":\"id\"},{\"description\":\"ISO 3166-1 alpha-3 code\",\"name\":\"iso3\",\"type\":\"id\"},{\"description\":\"ISO 3166-1 numeric code\",\"name\":\"iso_numeric\",\"type\":\"id\"},{\"description\":\"name\",\"name\":\"name\",\"type\":\"property\"}],\"format\":\"topojson\",\"id\":\"world_countries\",\"isEMS\":true,\"layerId\":\"elastic_maps_service.World Countries\",\"meta\":{\"feature_collection_path\":\"data\"},\"name\":\"World Countries\",\"origin\":\"elastic_maps_service\"},\"showAllShapes\":true,\"wms\":{\"enabled\":false,\"options\":{\"attribution\":\"\",\"format\":\"image/png\",\"layers\":\"\",\"styles\":\"\",\"transparent\":true,\"version\":\"\"},\"selectedTmsLayer\":{\"attribution\":\"<a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.openstreetmap.org/copyright\\\">OpenStreetMap contributors</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://openmaptiles.org\\\">OpenMapTiles</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.elastic.co/elastic-maps-service\\\">Elastic Maps Service</a>\",\"id\":\"road_map\",\"maxZoom\":20,\"minZoom\":0,\"origin\":\"elastic_maps_service\"},\"url\":\"\"}},\"title\":\"region_map\",\"type\":\"region_map\"}"},"coreMigrationVersion":"7.17.5","id":"64a5b9f0-1e6b-11ed-833b-a105e9534fa9","migrationVersion":{"visualization":"7.17.0"},"references":[{"id":"90943e30-9a47-11e8-b64d-95841ca0b247","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"visualization","updated_at":"2022-08-17T20:30:50.288Z","version":"WzE0MDIsMV0="} {"attributes":{"description":"","kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"\",\"language\":\"kuery\"},\"filter\":[],\"indexRefName\":\"kibanaSavedObjectMeta.searchSourceJSON.index\"}"},"title":"tile_map","uiStateJSON":"{\"mapZoom\":2,\"mapCenter\":[13.64385981167601,-135.97675761558068]}","version":1,"visState":"{\"title\":\"tile_map\",\"type\":\"tile_map\",\"aggs\":[{\"id\":\"1\",\"enabled\":true,\"type\":\"count\",\"params\":{},\"schema\":\"metric\"},{\"id\":\"2\",\"enabled\":true,\"type\":\"geohash_grid\",\"params\":{\"field\":\"geo.coordinates\",\"autoPrecision\":true,\"precision\":2,\"useGeocentroid\":true,\"isFilteredByCollar\":true},\"schema\":\"segment\"}],\"params\":{\"colorSchema\":\"Yellow to Red\",\"mapType\":\"Scaled Circle Markers\",\"isDesaturated\":true,\"addTooltip\":true,\"heatClusterSize\":1.5,\"legendPosition\":\"bottomright\",\"mapZoom\":2,\"mapCenter\":[0,0],\"wms\":{\"enabled\":false,\"url\":\"\",\"options\":{\"version\":\"\",\"layers\":\"\",\"format\":\"image/png\",\"transparent\":true,\"attribution\":\"\",\"styles\":\"\"},\"selectedTmsLayer\":{\"origin\":\"elastic_maps_service\",\"id\":\"road_map\",\"minZoom\":0,\"maxZoom\":20,\"attribution\":\"<a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.openstreetmap.org/copyright\\\">OpenStreetMap contributors</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://openmaptiles.org\\\">OpenMapTiles</a> | <a rel=\\\"noreferrer noopener\\\" href=\\\"https://www.elastic.co/elastic-maps-service\\\">Elastic Maps Service</a>\"}}}}"},"coreMigrationVersion":"7.17.5","id":"4b073190-1e6b-11ed-833b-a105e9534fa9","migrationVersion":{"visualization":"7.17.0"},"references":[{"id":"90943e30-9a47-11e8-b64d-95841ca0b247","name":"kibanaSavedObjectMeta.searchSourceJSON.index","type":"index-pattern"}],"type":"visualization","updated_at":"2022-08-17T20:29:28.769Z","version":"WzEzNDksMV0="} {"attributes":{"description":"","hits":0,"kibanaSavedObjectMeta":{"searchSourceJSON":"{\"query\":{\"query\":\"\",\"language\":\"kuery\"},\"filter\":[]}"},"optionsJSON":"{\"useMargins\":true,\"syncColors\":false,\"hidePanelTitles\":false}","panelsJSON":"[{\"version\":\"7.17.5\",\"type\":\"visualization\",\"gridData\":{\"x\":24,\"y\":0,\"w\":24,\"h\":15,\"i\":\"ad02c99b-8bae-42e0-8a43-d27762f1e607\"},\"panelIndex\":\"ad02c99b-8bae-42e0-8a43-d27762f1e607\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_ad02c99b-8bae-42e0-8a43-d27762f1e607\"},{\"version\":\"7.17.5\",\"type\":\"visualization\",\"gridData\":{\"x\":0,\"y\":0,\"w\":24,\"h\":15,\"i\":\"8412ffc8-b94c-4bbd-aa55-fa670f3fb4ee\"},\"panelIndex\":\"8412ffc8-b94c-4bbd-aa55-fa670f3fb4ee\",\"embeddableConfig\":{\"enhancements\":{}},\"panelRefName\":\"panel_8412ffc8-b94c-4bbd-aa55-fa670f3fb4ee\"}]","timeRestore":false,"title":"dash with legacy map visualizations","version":1},"coreMigrationVersion":"7.17.5","id":"97437d70-1e6b-11ed-833b-a105e9534fa9","migrationVersion":{"dashboard":"7.17.3"},"references":[{"id":"64a5b9f0-1e6b-11ed-833b-a105e9534fa9","name":"ad02c99b-8bae-42e0-8a43-d27762f1e607:panel_ad02c99b-8bae-42e0-8a43-d27762f1e607","type":"visualization"},{"id":"4b073190-1e6b-11ed-833b-a105e9534fa9","name":"8412ffc8-b94c-4bbd-aa55-fa670f3fb4ee:panel_8412ffc8-b94c-4bbd-aa55-fa670f3fb4ee","type":"visualization"}],"type":"dashboard","updated_at":"2022-08-17T20:31:36.656Z","version":"WzE0MzEsMV0="} {"excludedObjects":[],"excludedObjectsCount":0,"exportedCount":4,"missingRefCount":0,"missingReferences":[]} ``` * Open dashboard and verify tile_map renders --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

nreese added 4 commits July 12, 2021 12:54

[maps] remove tile_map plugin

264fbf6

initial bounds

5844deb

update embeddable query context

0c15b0c

start editor

1bb6c05

nreese added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jul 12, 2021

nreese requested review from a team as code owners July 12, 2021 20:34

nreese mentioned this pull request Jul 12, 2021

[maps] saved object migration to migrate tile_map and region_map visualizations to maps #105115

Closed

kibanamachine and others added 6 commits July 13, 2021 16:15

Merge branch 'master' into remove_tile_map

02902bb

remove tile_map from tsconfig and i18n cleanup

ebbb79f

implement view in maps button

7c3f745

tslint

4270a34

remove empty lines

3e1b263

remove tileMap from limits.yml

a9d28d3

nreese requested a review from a team as a code owner July 14, 2021 19:22

spalger marked this pull request as draft July 14, 2021 19:31

remove region_map and maps_legacy plugins

e0f1693

nreese changed the title ~~[maps] remove tile_map plugin~~ [maps] remove tile_map, region_map, and maps_legacy plugins Jul 14, 2021

nreese added 5 commits July 14, 2021 14:41

region_map vis with Map embeddable

fabb710

make MapComponent

f06e1d5

lint

da39da1

clean up

4649f51

shorten text

5326b58

ThomThomson approved these changes Aug 9, 2021

View reviewed changes

nreese added 3 commits August 11, 2021 08:24

merge with master

07b6328

Merge branch 'remove_tile_map' of github.com:nreese/kibana into remov…

ca3141e

…e_tile_map

remove deleted plugins from codeowners

2dc9a5e

thomasneirynck reviewed Aug 12, 2021

View reviewed changes

kibanamachine and others added 2 commits August 13, 2021 10:58

Merge branch 'master' into remove_tile_map

8aea3fa

review feedback

f935259

nreese requested a review from thomasneirynck August 13, 2021 15:24

nreese added 3 commits August 13, 2021 09:49

use correct value for TILE_MAP_RENDER

09d7ee2

down select mapModules for getLayerDescriptors callback

568f1ee

merge with master

410a8a1

thomasneirynck approved these changes Aug 18, 2021

View reviewed changes

nreese merged commit dd9dd52 into elastic:master Aug 18, 2021

This was referenced Aug 18, 2021

[Meta] 8.0 Kibana deprecations #109166

Closed

[Breaking change] Remove Coordinate map and region map visualizations #81703

Closed

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 20, 2021

nreese added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Aug 20, 2021

nreese mentioned this pull request Oct 5, 2021

[Maps] Switch to SavedObjectClient.resolve #112606

Merged

2samueld mentioned this pull request Nov 3, 2021

Fix max zoom warning behavior Tengda-He/kibana#24

Merged

nreese mentioned this pull request Apr 4, 2023

[Visualize] fix tile_map visualization #154392

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[maps] remove tile_map, region_map, and maps_legacy plugins #105326

[maps] remove tile_map, region_map, and maps_legacy plugins #105326

nreese commented Jul 12, 2021 •

edited

Loading

elasticmachine commented Jul 12, 2021

kibanamachine commented Jul 12, 2021 •

edited

Loading

nreese commented Jul 13, 2021

spalger commented Jul 14, 2021

kibanamachine commented Jul 14, 2021

ThomThomson left a comment

ThomThomson Aug 9, 2021

thomasneirynck left a comment

nreese commented Aug 12, 2021

nreese commented Aug 13, 2021

thomasneirynck left a comment

kibanamachine commented Aug 18, 2021

API count

API count missing comments

async chunk count

References to deprecated APIs

kibanamachine commented Aug 20, 2021

nreese commented Aug 20, 2021

	if (!showMapVisualizationTypes) {
	visualizations.hideTypes(['region_map', 'tile_map']);
	}

[maps] remove tile_map, region_map, and maps_legacy plugins #105326

[maps] remove tile_map, region_map, and maps_legacy plugins #105326

Conversation

nreese commented Jul 12, 2021 • edited Loading

elasticmachine commented Jul 12, 2021

kibanamachine commented Jul 12, 2021 • edited Loading

⏳ Build in-progress, with failures

Failed CI Steps

nreese commented Jul 13, 2021

spalger commented Jul 14, 2021

kibanamachine commented Jul 14, 2021

⏳ Build in-progress, with failures

Failed CI Steps

History

ThomThomson left a comment

Choose a reason for hiding this comment

ThomThomson Aug 9, 2021

Choose a reason for hiding this comment

thomasneirynck left a comment

Choose a reason for hiding this comment

nreese commented Aug 12, 2021

nreese commented Aug 13, 2021

thomasneirynck left a comment

Choose a reason for hiding this comment

kibanamachine commented Aug 18, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

API count

API count missing comments

async chunk count

References to deprecated APIs

History

kibanamachine commented Aug 20, 2021

nreese commented Aug 20, 2021

nreese commented Jul 12, 2021 •

edited

Loading

kibanamachine commented Jul 12, 2021 •

edited

Loading