Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] remove tile_map, region_map, and maps_legacy plugins #105326

Merged
merged 40 commits into from
Aug 18, 2021
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
264fbf6
[maps] remove tile_map plugin
nreese Jul 12, 2021
5844deb
initial bounds
nreese Jul 12, 2021
0c15b0c
update embeddable query context
nreese Jul 12, 2021
1bb6c05
start editor
nreese Jul 12, 2021
02902bb
Merge branch 'master' into remove_tile_map
kibanamachine Jul 13, 2021
ebbb79f
remove tile_map from tsconfig and i18n cleanup
nreese Jul 13, 2021
7c3f745
implement view in maps button
nreese Jul 14, 2021
4270a34
tslint
nreese Jul 14, 2021
3e1b263
remove empty lines
nreese Jul 14, 2021
a9d28d3
remove tileMap from limits.yml
nreese Jul 14, 2021
e0f1693
remove region_map and maps_legacy plugins
nreese Jul 14, 2021
fabb710
region_map vis with Map embeddable
nreese Jul 14, 2021
f06e1d5
make MapComponent
nreese Jul 14, 2021
da39da1
lint
nreese Jul 14, 2021
4649f51
clean up
nreese Jul 14, 2021
5326b58
shorten text
nreese Jul 14, 2021
1f6103f
lint
nreese Jul 15, 2021
a08767e
remove region_map from interpreter functional tests
nreese Jul 15, 2021
65fb20f
Merge branch 'master' of github.com:elastic/kibana into remove_tile_map
nreese Jul 15, 2021
1cb156a
update docs
nreese Jul 15, 2021
8f7cafe
add migration for removing ui_settings
nreese Jul 16, 2021
3ed555b
remove tile_map and region_map functional tests
nreese Jul 16, 2021
dca94cb
tslint
nreese Jul 16, 2021
203e7b4
merge with master
nreese Aug 2, 2021
a301fd8
call handlers.done when layers are loaded
nreese Aug 3, 2021
358757e
fix visualize create menu test
nreese Aug 4, 2021
c5a742d
Merge branch 'master' into remove_tile_map
kibanamachine Aug 4, 2021
1af2c2d
eslint
nreese Aug 4, 2021
9882f79
add owner comment to ui_settings/saved_objects/migrations.ts
nreese Aug 4, 2021
9cafeb4
merge with master
nreese Aug 4, 2021
c91114b
Merge branch 'master' into remove_tile_map
kibanamachine Aug 9, 2021
89350e9
Merge branch 'master' into remove_tile_map
kibanamachine Aug 9, 2021
07b6328
merge with master
nreese Aug 11, 2021
ca3141e
Merge branch 'remove_tile_map' of github.com:nreese/kibana into remov…
nreese Aug 11, 2021
2dc9a5e
remove deleted plugins from codeowners
nreese Aug 11, 2021
8aea3fa
Merge branch 'master' into remove_tile_map
kibanamachine Aug 13, 2021
f935259
review feedback
nreese Aug 13, 2021
09d7ee2
use correct value for TILE_MAP_RENDER
nreese Aug 13, 2021
568f1ee
down select mapModules for getLayerDescriptors callback
nreese Aug 13, 2021
410a8a1
merge with master
nreese Aug 18, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@
"kbnDocViews": "src/legacy/core_plugins/kbn_doc_views",
"lists": "packages/kbn-securitysolution-list-utils/src",
"management": ["src/legacy/core_plugins/management", "src/plugins/management"],
"maps_legacy": "src/plugins/maps_legacy",
"monaco": "packages/kbn-monaco/src",
"esQuery": "packages/kbn-es-query/src",
"presentationUtil": "src/plugins/presentation_util",
Expand All @@ -48,14 +47,12 @@
"kibana_utils": "src/plugins/kibana_utils",
"navigation": "src/plugins/navigation",
"newsfeed": "src/plugins/newsfeed",
"regionMap": "src/plugins/region_map",
"savedObjects": "src/plugins/saved_objects",
"savedObjectsManagement": "src/plugins/saved_objects_management",
"security": "src/plugins/security_oss",
"server": "src/legacy/server",
"statusPage": "src/legacy/core_plugins/status_page",
"telemetry": ["src/plugins/telemetry", "src/plugins/telemetry_management_section"],
"tileMap": "src/plugins/tile_map",
"timelion": ["src/plugins/timelion", "src/plugins/vis_type_timelion"],
"uiActions": "src/plugins/ui_actions",
"visDefaultEditor": "src/plugins/vis_default_editor",
Expand Down
12 changes: 0 additions & 12 deletions docs/developer/plugin-list.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,6 @@ management section itself.
|Configuration of kibana-wide EMS settings and some higher level utilities.


|{kib-repo}blob/{branch}/src/plugins/maps_legacy/README.md[mapsLegacy]
|Internal objects used by the Coordinate, Region, and Vega visualizations.


|{kib-repo}blob/{branch}/src/plugins/navigation/README.md[navigation]
|The navigation plugins exports the TopNavMenu component.
It also provides a stateful version of it on the start contract.
Expand All @@ -200,10 +196,6 @@ Content is fetched from the remote (https://feeds.elastic.co and https://feeds-s
|The Presentation Utility Plugin is a set of common, shared components and toolkits for solutions within the Presentation space, (e.g. Dashboards, Canvas).


|{kib-repo}blob/{branch}/src/plugins/region_map/README.md[regionMap]
|Create choropleth maps. Display the results of a term-aggregation as e.g. countries, zip-codes, states.


|{kib-repo}blob/{branch}/src/plugins/saved_objects/README.md[savedObjects]
|NOTE: This plugin is deprecated and will be removed in 8.0. See https://github.com/elastic/kibana/issues/46435 for more information.

Expand Down Expand Up @@ -247,10 +239,6 @@ generating deep links to other apps, and creating short URLs.
|This plugin adds the Advanced Settings section for the Usage and Security Data collection (aka Telemetry).


|{kib-repo}blob/{branch}/src/plugins/tile_map/README.md[tileMap]
|Create a coordinate map. Display the results of a geohash_tile aggregation as bubbles, rectangles, or heatmap color blobs.


|{kib-repo}blob/{branch}/src/plugins/timelion/README.md[timelion]
|Contains the deprecated timelion application. For the timelion visualization,
which also contains the timelion APIs and backend, look at the vis_type_timelion plugin.
Expand Down
13 changes: 1 addition & 12 deletions docs/management/advanced-options.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -534,17 +534,6 @@ of the chart. Use numbers between 0 and 1. The lower the number, the more the hi
[[visualization-heatmap-maxbuckets]]`visualization:heatmap:maxBuckets`::
The maximum number of buckets a datasource can return. High numbers can have a negative impact on your browser rendering performance.

[[visualization-regionmap-showwarnings]]`visualization:regionmap:showWarnings`::
Shows a warning in a region map when terms cannot be joined to a shape.

[[visualization-tilemap-wmsdefaults]]`visualization:tileMap:WMSdefaults`::
The default properties for the WMS map server supported in the coordinate map.

[[visualization-tilemap-maxprecision]]`visualization:tileMap:maxPrecision`::
The maximum geoHash precision displayed in tile maps. 7 is high, 10 is very high,
and 12 is the maximum. For more information, refer to
{ref}/search-aggregations-bucket-geohashgrid-aggregation.html#_cell_dimensions_at_the_equator[Cell dimensions at the equator].

[[visualization-visualize-chartslibrary]]`visualization:visualize:legacyChartsLibrary`::
**The legacy XY charts are deprecated and will not be supported as of 7.16.**
The visualize editor uses a new XY charts library with improved performance, color palettes, fill capacity, and more. Enable this option if you prefer to use the legacy charts library.
Expand All @@ -563,4 +552,4 @@ only production-ready visualizations are available to users.
[horizontal]
[[telemetry-enabled-advanced-setting]]`telemetry:enabled`::
When enabled, helps improve the Elastic Stack by providing usage statistics for
basic features. This data will not be shared outside of Elastic.
basic features. This data will not be shared outside of Elastic.
4 changes: 0 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -281,10 +281,6 @@
"jsonwebtoken": "^8.5.1",
"jsts": "^1.6.2",
"kea": "^2.4.2",
"leaflet": "1.5.1",
nreese marked this conversation as resolved.
Show resolved Hide resolved
"leaflet-draw": "0.4.14",
"leaflet-responsive-popup": "0.6.4",
"leaflet.heat": "0.2.0",
"less": "npm:@elastic/less@2.7.3-kibana",
"load-json-file": "^6.2.0",
"loader-utils": "^1.2.3",
Expand Down
5 changes: 1 addition & 4 deletions packages/kbn-optimizer/limits.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,13 @@ pageLoadAssetSize:
lists: 22900
logstash: 53548
management: 46112
maps: 80000
mapsLegacy: 87859
maps: 90000
ml: 82187
monitoring: 80000
navigation: 37269
newsfeed: 42228
observability: 89709
painlessLab: 179748
regionMap: 66098
remoteClusters: 51327
reporting: 183418
rollup: 97204
Expand All @@ -75,7 +73,6 @@ pageLoadAssetSize:
spaces: 57868
telemetry: 51957
telemetryManagementSection: 38586
tileMap: 65337
timelion: 29920
transform: 41007
triggersActionsUi: 100000
Expand Down
35 changes: 35 additions & 0 deletions src/core/server/ui_settings/saved_objects/migrations.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,3 +128,38 @@ describe('ui_settings 7.13.0 migrations', () => {
});
});
});

describe('ui_settings 8.0.0 migrations', () => {
const migration = migrations['8.0.0'];

test('returns doc on empty object', () => {
expect(migration({} as SavedObjectUnsanitizedDoc)).toEqual({
references: [],
});
});
test('removes ui_settings from deleted region_map and tile_map plugins', () => {
const doc = {
type: 'config',
id: '8.0.0',
attributes: {
buildNum: 9007199254740991,
'visualization:regionmap:showWarnings': false,
'visualization:tileMap:WMSdefaults': '{}',
'visualization:tileMap:maxPrecision': 10,
},
references: [],
updated_at: '2020-06-09T20:18:20.349Z',
migrationVersion: {},
};
expect(migration(doc)).toEqual({
type: 'config',
id: '8.0.0',
attributes: {
buildNum: 9007199254740991,
},
references: [],
updated_at: '2020-06-09T20:18:20.349Z',
migrationVersion: {},
});
});
});
23 changes: 23 additions & 0 deletions src/core/server/ui_settings/saved_objects/migrations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,27 @@ export const migrations = {
}),
references: doc.references || [],
}),
'8.0.0': (doc: SavedObjectUnsanitizedDoc<any>): SavedObjectSanitizedDoc<any> => ({
...doc,
...(doc.attributes && {
// owner: Team:Geo
attributes: Object.keys(doc.attributes).reduce(
(acc, key) =>
[
'visualization:regionmap:showWarnings',
nreese marked this conversation as resolved.
Show resolved Hide resolved
'visualization:tileMap:WMSdefaults',
'visualization:tileMap:maxPrecision',
].includes(key)
? {
...acc,
}
: {
...acc,
[key]: doc.attributes[key],
},
{}
),
}),
references: doc.references || [],
}),
};
7 changes: 0 additions & 7 deletions src/plugins/maps_legacy/README.md

This file was deleted.

13 changes: 0 additions & 13 deletions src/plugins/maps_legacy/config.ts

This file was deleted.

13 changes: 0 additions & 13 deletions src/plugins/maps_legacy/jest.config.js

This file was deleted.

9 changes: 0 additions & 9 deletions src/plugins/maps_legacy/kibana.json

This file was deleted.

23 changes: 0 additions & 23 deletions src/plugins/maps_legacy/public/common/types.ts

This file was deleted.

This file was deleted.

Loading