-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[maps] remove xpack.maps.showMapVisualizationTypes #105979
[maps] remove xpack.maps.showMapVisualizationTypes #105979
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
Was this configuration already deprecated on the 7.x branch? I'm not finding a deprecation notice in the source tree. |
@joshdover What do you mean exactly with "deprecated". ie. logging a warning message on startup? fyi #105981 |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just added 1 NIT. Thanks for extending our @kbn/telemetry-tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Operations: LGTM
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, tested and works. Super nice to see this come together.
fwiw - only looked at maps-changes, not the telemetry ones.
We will also need to remove the corresponding configuration from Cloud.
https://github.com/elastic/cloud/search?q=xpack.maps.showMapVisualizationTypes
Could you open a corresponding issue in the Cloud repo? I think these types of changes are handled in batch on the cloud-side. Thx.
Created https://github.com/elastic/cloud/issues/87294 to track removal of xpack.maps.showMapVisualizationTypes in cloud |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Added backport:skip label. This change is 8.0 only |
Remove
xpack.maps.showMapVisualizationTypes
kibana.yml settings. With removal of tile_map and region_map plugins, this setting no longer has any use.Telemetry checker updates:
This PR adds a couple of previously unsupported features in the
telemetry_check
parser.@Bamieh pushed fixes needed by telemtry to support enums in type interface collector. These changes were required to resolve telemetry build failures between the schema and the usage ts Type matches.
Added in the same PR rather than a separate one to help unblock this PR faster.
Add support for computed terms:
Usage type
Schema
Add support for enums
Usage type
Schema