Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text for optional endpoint for PagerDuty connector #63768

Closed
alexfrancoeur opened this issue Apr 16, 2020 · 1 comment · Fixed by #64032
Closed

Add text for optional endpoint for PagerDuty connector #63768

alexfrancoeur opened this issue Apr 16, 2020 · 1 comment · Fixed by #64032
Assignees
@pmuellr
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@alexfrancoeur
Copy link

image

Our docs say that we default to a specific endpoint for the PagerDuty action
https://www.elastic.co/guide/en/kibana/7.x/pagerduty-action-type.html

An optional PagerDuty event URL. Defaults to https://events.pagerduty.com/v2/enqueue. If you are using the xpack.actions.whitelistedHosts setting, make sure the hostname is whitelisted.

In some form or another we should either show the default or say it's optional to add
@alexfrancoeur alexfrancoeur added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Apr 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@alexfrancoeur alexfrancoeur changed the title Add text for option endpoint for PagerDuty connector Add text for optional endpoint for PagerDuty connector Apr 16, 2020
@alexfrancoeur alexfrancoeur mentioned this issue Apr 17, 2020
Merged
@pmuellr pmuellr self-assigned this Apr 21, 2020
pmuellr added a commit to pmuellr/kibana that referenced this issue Apr 21, 2020
@pmuellr
[Alerting] fix labels and links in PagerDuty action ui and docs
ae2d51c 
resolves elastic#63222, resolves elastic#63768, resolves elastic#63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
@pmuellr pmuellr mentioned this issue Apr 21, 2020
Merged
2 tasks
pmuellr added a commit that referenced this issue May 4, 2020
@pmuellr
[Alerting] fix labels and links in PagerDuty action ui and docs (#64032)
cb00e5e 
resolves #63222, resolves #63768, resolves #63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
pmuellr added a commit to pmuellr/kibana that referenced this issue May 4, 2020
@pmuellr
[Alerting] fix labels and links in PagerDuty action ui and docs (elas…
988d9d4 
…tic#64032)

resolves elastic#63222, resolves elastic#63768, resolves elastic#63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
pmuellr added a commit that referenced this issue May 4, 2020
@pmuellr
[Alerting] fix labels and links in PagerDuty action ui and docs (#64032…
71c14c6 
…) (#65075)

resolves #63222, resolves #63768, resolves #63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
pmuellr added a commit to pmuellr/kibana that referenced this issue May 18, 2020
@pmuellr
[Alerting] fix labels and links in PagerDuty action ui and docs (elas…
f0d6c2e 
…tic#64032)

resolves elastic#63222, resolves elastic#63768, resolves elastic#63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
pmuellr added a commit that referenced this issue May 18, 2020
@pmuellr
[Alerting] fix labels and links in PagerDuty action ui and docs (#64032…
477ed19 
…) (#66895)

resolves #63222, resolves #63768, resolves #63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmuellr pmuellr

Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Alerting] fix labels and links in PagerDuty action ui and docs pmuellr/kibana
4 participants
@pmuellr @kobelb @elasticmachine @alexfrancoeur