Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PagerDuty Connector's key name #63222

Closed
arisonl opened this issue Apr 10, 2020 · 8 comments · Fixed by #64032
Closed

PagerDuty Connector's key name #63222

arisonl opened this issue Apr 10, 2020 · 8 comments · Fixed by #64032
Assignees
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.1

Comments

@arisonl
Copy link
Contributor

arisonl commented Apr 10, 2020

PagerDuty offers two ways to integrate: Through "Global routing" (with a "routing" key) and through a Service (with an integration key). While playing around with PD, I have managed to set up connectors using the integration key but not with the "routing" key. While I am unsure at this point if the "routing key" path is possible, the integration key option works. However, we refer to the key on our Connectors UI as the “routing” key. This might cause confusion to the user that sets up the Connector.

PagerDuty:
Screenshot 2020-04-10 at 12 04 20

Our Connector:
Screenshot 2020-04-10 at 12 04 34

cc: @YulNaumenko @pmuellr

@arisonl arisonl added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Apr 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr pmuellr self-assigned this Apr 14, 2020
@pmuellr
Copy link
Member

pmuellr commented Apr 14, 2020

Sadly, the PD APIs make this a little confusing.

Technically, we only support the Events API v2. Under "Getting Started", you'll see the following:

You will need to include the integration key for your new integration, as a routing_key in the event payload.

So, it's both an "integration" key, and a "routing" key, depending on how you look at it.

I wasn't familiar with "Global routing", but some GOOGling yielded this page: Global Event Rules API. Which has this bit of text in it, under Parameters / Other Fields:

external_id The global event rules routing key.

Which sounds like in this case, the property name is external_id but is described as a "routing" key.

Sigh.

@pmuellr
Copy link
Member

pmuellr commented Apr 14, 2020

Just to make it a little more confusing, the link in the connector editor points to some watcher docs:

image

The "Configure a PagerDuty account." link takes you here: https://www.elastic.co/guide/en/elasticsearch/reference/current/actions-pagerduty.html#configuring-pagerduty

Steps 1, 2, and 3 are all correct there, but then it starts talking about a keystore, and is then venturing into Watcher action specifics.

@pmuellr
Copy link
Member

pmuellr commented Apr 14, 2020

Our current doc I think gets it about right:

https://www.elastic.co/guide/en/kibana/7.7/action-types.html#pagerduty-action-type

Routing Key
A 32 character PagerDuty Integration Key for an integration on a service or on a global ruleset.

@pmuellr
Copy link
Member

pmuellr commented Apr 14, 2020

Here are my current thoughts on changes:

  • change the copy in the connector editor from "Routing key" to "Integration key"
  • change the link in the connector editor from the watcher docs to the alerting docs for the PD actions
  • change the alerting docs for the PD action to point to the watcher docs (in terms of directions on how to create an integration key), and change the referenced "Routing key" name to "Integration key". Probably also mention that in the Pagerduty v2 event API, the "Integration key" is used as the value of the routing_key property.

@arisonl
Copy link
Contributor Author

arisonl commented Apr 14, 2020

Thank you @pmuellr! That makes sense. On your third point and partly on the second as well: We are putting together integration documentation for PD, here is the draft: https://docs.google.com/document/d/19wsl6uqXiBfNSD6hArVzrSYnyoD2E4agd-eSKvRErBM/edit#heading=h.dnnu0dp93okx It is to an extent why we need this split: #62445

@pmuellr
Copy link
Member

pmuellr commented Apr 15, 2020

I was going to start in on this, but it seems like a 7.7.1 thing, and we need to wait for the action doc pages to be split before changing them, so moving back to unassigned.

@pmuellr pmuellr removed their assignment Apr 15, 2020
@pmuellr pmuellr added the v7.7.1 label Apr 15, 2020
@mikecote
Copy link
Contributor

mikecote commented Apr 16, 2020

Action types split PR is now merged and backported.

@pmuellr pmuellr self-assigned this Apr 17, 2020
pmuellr added a commit to pmuellr/kibana that referenced this issue Apr 21, 2020
resolves elastic#63222, resolves elastic#63768, resolves elastic#63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
pmuellr added a commit that referenced this issue May 4, 2020
resolves #63222, resolves #63768, resolves #63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
pmuellr added a commit to pmuellr/kibana that referenced this issue May 4, 2020
…tic#64032)

resolves elastic#63222, resolves elastic#63768, resolves elastic#63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
pmuellr added a commit that referenced this issue May 4, 2020
…) (#65075)

resolves #63222, resolves #63768, resolves #63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
pmuellr added a commit to pmuellr/kibana that referenced this issue May 18, 2020
…tic#64032)

resolves elastic#63222, resolves elastic#63768, resolves elastic#63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
pmuellr added a commit that referenced this issue May 18, 2020
…) (#66895)

resolves #63222, resolves #63768, resolves #63223

ui changes:

- adds an "(optional)" label after the API URL label
- changes help link to go to alerting docs and not watcher docs
- changes the label "Routing key" to "Integration key" to match other docs
- changes the order of the severity options to match other docs

doc changes:

- changes the reference of "Routing key" to "Integration key" to match other docs
- makes clearer that the API URL is optional
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants