-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JenkinsFiles for xLinux large heap #1884
Conversation
9: '/usr/lib/jvm/adoptojdk-java-80' | ||
10: '/usr/lib/jvm/adoptojdk-java-90' | ||
release: | ||
8: 'linux-x86_64-normal-server-release' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this value used? It's identical between this build and the compressed refs one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the folder the OpenJDK compile dumps the bins into. Which has nothing to do with the VM afaik.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use it for JAVA_BIN.
see https://github.com/eclipse/openj9/blob/master/buildenv/jenkins/common/test
line 23-34
And when we tar up the SDK
@vsebe Can you review this? |
@AdamBrousseau I continue to be concerned about the duplication between these different build files. Copy & paste code often leads to bugs due to missing an update in some of the files. I don't want to block this PR over this though its essential that the overall approach is rethought to remove the duplication. |
Agree. I will open an issue to follow up with a refactor |
b356b7c
to
fd08625
Compare
^ #1897 |
- Add files for: - Build - Sanity - Extended - PRs - Nightly Pipelines - Add linux_x86-64 spec to varialbles file [skip ci] Issue eclipse-openj9#1669 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
4423bcb
to
d324012
Compare
jenkins compile xlinuxlargeheap |
jenkins test all xlinuxlargeheap |
@AdamBrousseau @DanHeidinga, Pull requests are completed for xlinuxlargeheap. |
Cautiously asks - are they expected to pass? Looks like they were aborted... |
I think Joe was just testing the triggers were setup and working as expected. The "build part" should be the same as the nightlies which have already been tested |
extended testing covered by #1937 |
- Add linux_x86-64 spec - Run JDK8,10 [skip ci] Issue eclipse-openj9#1669 Depends eclipse-openj9#1884 Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
xlinuxlargeheap didn't get added to the list in https://github.com/eclipse/openj9/tree/master/buildenv/jenkins |
Issue eclipse-openj9#1884 eclipse-openj9#1669 [skip ci] Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
[skip ci]
Issue #1669
Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com
Status