Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JenkinsFiles for xLinux large heap #1884

Merged
merged 1 commit into from
May 18, 2018

Conversation

AdamBrousseau
Copy link
Contributor

@AdamBrousseau AdamBrousseau commented May 10, 2018

  • Add files for:
    • Build
    • Sanity
    • Extended
    • PRs
    • Nightly Pipelines
  • Add linux_x86-64 spec to varialbles file

[skip ci]

Issue #1669

Signed-off-by: Adam Brousseau adam.brousseau88@gmail.com

Status

  • Build
    • 8 Build Status
    • 9 Build Status
    • 10 Build Status
  • Sanity
    • 8 Build Status
    • 9 Build Status
    • 10 Build Status
  • Extended
    • 8 Build Status
    • 9 Build Status
    • 10 Build Status

9: '/usr/lib/jvm/adoptojdk-java-80'
10: '/usr/lib/jvm/adoptojdk-java-90'
release:
8: 'linux-x86_64-normal-server-release'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this value used? It's identical between this build and the compressed refs one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the folder the OpenJDK compile dumps the bins into. Which has nothing to do with the VM afaik.

Copy link
Contributor Author

@AdamBrousseau AdamBrousseau May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use it for JAVA_BIN.
see https://github.com/eclipse/openj9/blob/master/buildenv/jenkins/common/test
line 23-34
And when we tar up the SDK

@DanHeidinga
Copy link
Member

@vsebe Can you review this?

@DanHeidinga
Copy link
Member

@AdamBrousseau I continue to be concerned about the duplication between these different build files. Copy & paste code often leads to bugs due to missing an update in some of the files.

I don't want to block this PR over this though its essential that the overall approach is rethought to remove the duplication.

@AdamBrousseau
Copy link
Contributor Author

Agree. I will open an issue to follow up with a refactor

@AdamBrousseau
Copy link
Contributor Author

^ #1897

- Add files for:
   - Build
   - Sanity
   - Extended
   - PRs
   - Nightly Pipelines
- Add linux_x86-64 spec to varialbles file

[skip ci]

Issue eclipse-openj9#1669

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@jdekonin
Copy link
Contributor

jenkins compile xlinuxlargeheap

@jdekonin
Copy link
Contributor

jenkins test all xlinuxlargeheap

@jdekonin
Copy link
Contributor

@AdamBrousseau @DanHeidinga, Pull requests are completed for xlinuxlargeheap.

@DanHeidinga
Copy link
Member

Cautiously asks - are they expected to pass? Looks like they were aborted...

@AdamBrousseau
Copy link
Contributor Author

I think Joe was just testing the triggers were setup and working as expected. The "build part" should be the same as the nightlies which have already been tested

@AdamBrousseau AdamBrousseau changed the title WIP: Add JenkinsFiles for xLinux large heap Add JenkinsFiles for xLinux large heap May 18, 2018
@pshipton
Copy link
Member

extended testing covered by #1937

@pshipton pshipton merged commit 25d9350 into eclipse-openj9:master May 18, 2018
AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this pull request May 22, 2018
- Add linux_x86-64 spec
- Run JDK8,10

[skip ci]

Issue eclipse-openj9#1669
Depends eclipse-openj9#1884

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@pshipton
Copy link
Member

xlinuxlargeheap didn't get added to the list in https://github.com/eclipse/openj9/tree/master/buildenv/jenkins

AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this pull request Jun 13, 2018
Issue eclipse-openj9#1884 eclipse-openj9#1669
[skip ci]

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants