Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20243] Custom pools on DDS layer feature (backport #3755) #4246

Merged
merged 6 commits into from
Jan 17, 2024
Merged

[20243] Custom pools on DDS layer feature (backport #3755) #4246

merged 6 commits into from
Jan 17, 2024

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Jan 15, 2024 •
edited
Loading

Description

This pull request aims to expose the usage of a custom payload pool implementation on the DDS layer

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

JesusPoderoso and others added 3 commits January 15, 2024 14:48
@JesusPoderoso @jsan-rt
@MiguelCompany @rsanchez15
Custom pools on DDS layer feature (#3755)
7ed7efe 
* Custom Payload pools test implementation (#3719)

* Refs #19024: Public API implementation

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19024: Update versions.md

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Fix build issues

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Custom Payload pools test implementation

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

* Refs #19023: Update test to use public API

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Please linters

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>

* Refs #19023: Added delay between writing and checking payload request

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Include custom pools impl (#3740)

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024: Modified custom payload pool and datasharing interaction

Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

* Refs #19024. Correctly set payload owner on test pools.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>

---------

Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
Signed-off-by: Javier Santiago <javiersantiago@eprosima.com>
Signed-off-by: Eduardo Ponz <eduardoponz@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Co-authored-by: jsantiago-eProsima <90755661+jsantiago-eProsima@users.noreply.github.com>
Co-authored-by: Javier Santiago <javiersantiago@eprosima.com>
Co-authored-by: Miguel Company <MiguelCompany@eprosima.com>
@rsanchez15
Add API to create writers and readers with a custom payload pool
f42cbf5 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Use correct API in tests
7c58330 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15 rsanchez15 changed the title Backport #3755 - Custom pools on DDS layer feature [20243] Custom pools on DDS layer feature (backport #3755) Jan 15, 2024
@EduPonz EduPonz added this to the v2.10.3 milestone Jan 15, 2024
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

EduPonz
EduPonz suggested changes Jan 16, 2024
View reviewed changes
test/unittest/dds/subscriber/DataReaderTests.cpp Show resolved Hide resolved
versions.md Outdated Show resolved Hide resolved
@rsanchez15
Fix Window warning about asio include
378bd6a 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Copy link
Contributor Author

@richiprosima please test this

EduPonz
EduPonz previously approved these changes Jan 16, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@rsanchez15
Remove feature in forthcoming version file
34a31ab 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
EduPonz
EduPonz previously approved these changes Jan 16, 2024
View reviewed changes
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso
Copy link
Contributor

@richiprosima please test mac

@rsanchez15
Add Asio include dir to datareader tests
fe8fa0b 
Signed-off-by: Raul Sanchez-Mateos <raul@eprosima.com>
@rsanchez15
Copy link
Contributor Author

@richiprosima please test this

@EduPonz EduPonz merged commit cc281a1 into 2.10.x Jan 17, 2024
8 of 13 checks passed
@EduPonz EduPonz deleted the backport/3755 branch January 17, 2024 13:06
@rsanchez15 rsanchez15 mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.10.3
Development

Successfully merging this pull request may close these issues.
3 participants
@rsanchez15 @JesusPoderoso @EduPonz