Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Remove plots-to-appinsights. #8002

Merged
merged 1 commit into from
May 1, 2023
Merged

[ci] Remove plots-to-appinsights. #8002

merged 1 commit into from
May 1, 2023

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented May 1, 2023 •
edited
Loading

Commit ecb207b broke the plots-to-appinsights process that only gets run on main (not PR builds).

As we do not believe this data is consumed anymore, we are electing to remove it from CI rather than make the necessary updates to get it working again.

Note there are some alternatives to this data that are used today:

  • Unit tests that test build time and use apidiff to test apk size
  • MAUI maintains a dashboard of similar graphs for their builds, which are our builds.

@jpobst jpobst marked this pull request as ready for review May 1, 2023 20:21
pjcollins
pjcollins approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@pjcollins pjcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we now have better infrastructure for some of the timing data and app sizes that were being captured here, so it should be ok to disable this.

jonathanpeppers
jonathanpeppers approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment •
edited by jpobst
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have https://aka.ms/dotnetperfstatus now. (MS internal only)

@jpobst jpobst merged commit e694ba5 into main May 1, 2023
@jpobst jpobst deleted the remove-appinsights branch May 1, 2023 20:46
grendello added a commit to grendello/xamarin-android that referenced this pull request May 4, 2023
@grendello
Merge branch 'main' into blazor-hang
4b45d5f 
* main:
  Bump to dotnet/installer@0ce891843a 8.0.100-preview.5.23228.7 (dotnet#7994)
  [ci] Automatically retry failed emulator tests. (dotnet#7997)
  [xaprepare] Combine 'AndroidTestDependencies' and 'EmulatorTestDependencies' scenarios. (dotnet#8006)
  [xaprepare] Provision 'platform-33_r02' (dotnet#8004)
  [Xamarin.Android.Build.Tasks] Add AndroidEnableRestrictToAttributes (dotnet#7990)
  [ci] Remove plots-to-appinsights. (dotnet#8002)
  [Xamarin.Android.Build.Tasks] remove NuGet dependencies (dotnet#8000)
  Bump to 33.0.56 $(AndroidNet7Version) (dotnet#7998)
  $(AndroidPackVersionSuffix)=preview.5; net8 is 34.0.0-preview.5 (dotnet#7996)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@pjcollins pjcollins pjcollins approved these changes

@jonpryor jonpryor Awaiting requested review from jonpryor jonpryor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpobst @jonathanpeppers @pjcollins