[Xamarin.Android.Build.Tasks] remove NuGet dependencies #8000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In classic Xamarin.Android, we used some NuGet libraries in the
`<ResolveAssemblies/>` MSBuild task. We don't use this task at all in
.NET 6+, so we can remove these going forward.
I removed:
* NuGet dependencies
* Remaining usage of `<ResolveAssemblies/>` MSBuild task.
* Some tests for `<ResolveAssemblies/>` that used `packages.config`
and did not run for .NET 6+.
* The `PackagesConfig` NUnit category, as it is no longer used at all.
There is a decent file size saving from this change, just comparing
a local debug build vs .NET 7:
(ls "C:\Program Files\dotnet\packs\Microsoft.Android.Sdk.Windows\33.0.46\tools\Xamarin.Android.Build.Tasks.dll").Length
4493192
(ls "C:\src\xamarin-android\bin\Debug\dotnet\packs\Microsoft.Android.Sdk.Windows\34.0.0-ci.RemoveNuGetDependencies.273\tools\Xamarin.Android.Build.Tasks.dll").Length
2829824
Saves ~1.6MB from this assembly.
jonathanpeppers
requested review from
dellis1972,
pjcollins and
jonpryor
as code owners
pjcollins
approved these changes
Apr 28, 2023
dellis1972
approved these changes
Apr 28, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
May 4, 2023
* main: Bump to dotnet/installer@0ce891843a 8.0.100-preview.5.23228.7 (dotnet#7994) [ci] Automatically retry failed emulator tests. (dotnet#7997) [xaprepare] Combine 'AndroidTestDependencies' and 'EmulatorTestDependencies' scenarios. (dotnet#8006) [xaprepare] Provision 'platform-33_r02' (dotnet#8004) [Xamarin.Android.Build.Tasks] Add AndroidEnableRestrictToAttributes (dotnet#7990) [ci] Remove plots-to-appinsights. (dotnet#8002) [Xamarin.Android.Build.Tasks] remove NuGet dependencies (dotnet#8000) Bump to 33.0.56 $(AndroidNet7Version) (dotnet#7998) $(AndroidPackVersionSuffix)=preview.5; net8 is 34.0.0-preview.5 (dotnet#7996)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In classic Xamarin.Android, we used some NuGet libraries in the
<ResolveAssemblies/>MSBuild task. We don't use this task at all in .NET 6+, so we can remove these going forward.I removed:
NuGet dependencies
Remaining usage of
<ResolveAssemblies/>MSBuild task.Some tests for
<ResolveAssemblies/>that usedpackages.configand did not run for .NET 6+.The
PackagesConfigNUnit category, as it is no longer used at all.There is a decent file size saving from this change, just comparing a local debug build vs .NET 7:
Saves ~1.6MB from this assembly.