Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/installer #7994

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Apr 27, 2023

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.NETCore.App.Ref: from 8.0.0-preview.4.23221.1 to 8.0.0-preview.4.23225.14 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport: from 8.0.0-preview.4.23218.1 to 8.0.0-preview.4.23219.1 (parent: Microsoft.NETCore.App.Ref)
    • Microsoft.NET.ILLink.Tasks: from 8.0.0-preview.4.23221.1 to 8.0.0-preview.4.23225.14 (parent: Microsoft.Dotnet.Sdk.Internal)
    • Microsoft.DotNet.Cecil: from 0.11.4-alpha.23178.1 to 0.11.4-alpha.23218.2 (parent: Microsoft.NET.ILLink.Tasks)

From https://github.com/dotnet/installer

  • Subscription: 0ba14476-1d1a-452a-3b67-08da9690aef0
  • Build: 20230428.7
  • Date Produced: April 28, 2023 6:02:20 PM UTC
  • Commit: 0ce891843a4ee251d356cd429c596ba25ee15dc3
  • Branch: refs/heads/main

…230427.3

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.4.23224.14 -> To Version 8.0.100-preview.5.23227.3

Dependency coherency updates

Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport,Microsoft.NET.ILLink.Tasks,Microsoft.DotNet.Cecil
 From Version 8.0.0-preview.4.23221.1 -> To Version 8.0.0-preview.4.23225.14 (parent: Microsoft.Dotnet.Sdk.Internal
@jonathanpeppers
Copy link
Member

jonathanpeppers commented Apr 28, 2023

There is a new file here:

66,336 lib/arm64-v8a/libSystem.Globalization.Native.so *2

@akoeplinger mentioned we can remove it completely from all apps?

@jonathanpeppers
Copy link
Member

Found the PR: dotnet/runtime#82393

Next week, I'll look into making some private item group to exclude files. Similar to what we have for Mono components?

@akoeplinger
Copy link
Member

akoeplinger commented Apr 28, 2023

Correct, please let me know if you run into issues. Not sure if you use the static archive (.a) versions of the libs anywhere but it'd need the same treatment.

…230428.7

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.4.23224.14 -> To Version 8.0.100-preview.5.23228.7

Dependency coherency updates

Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport,Microsoft.NET.ILLink.Tasks,Microsoft.DotNet.Cecil
 From Version 8.0.0-preview.4.23221.1 -> To Version 8.0.0-preview.4.23225.14 (parent: Microsoft.Dotnet.Sdk.Internal
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one performance test failure Build_Designer_Change, but I don't see a regression here:

image

I think we can ignore it?

@jonathanpeppers jonathanpeppers merged commit c332cfc into main May 3, 2023
@jonathanpeppers jonathanpeppers deleted the darc-main-748d0d1d-4036-4a6a-940e-a73f65627e3c branch May 3, 2023 21:36
grendello added a commit to grendello/xamarin-android that referenced this pull request May 4, 2023
* main:
  Bump to dotnet/installer@0ce891843a 8.0.100-preview.5.23228.7 (dotnet#7994)
  [ci] Automatically retry failed emulator tests. (dotnet#7997)
  [xaprepare] Combine 'AndroidTestDependencies' and 'EmulatorTestDependencies' scenarios. (dotnet#8006)
  [xaprepare] Provision 'platform-33_r02' (dotnet#8004)
  [Xamarin.Android.Build.Tasks] Add AndroidEnableRestrictToAttributes (dotnet#7990)
  [ci] Remove plots-to-appinsights. (dotnet#8002)
  [Xamarin.Android.Build.Tasks] remove NuGet dependencies (dotnet#8000)
  Bump to 33.0.56 $(AndroidNet7Version) (dotnet#7998)
  $(AndroidPackVersionSuffix)=preview.5; net8 is 34.0.0-preview.5 (dotnet#7996)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants