Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension points #28

Merged

Conversation

aalmiray
Copy link
Contributor

Fix for #27.

  • Migrated all private state to protected for Field, SimpleControl and their subclasses.
  • Package private state was migrated to protected.
  • Package private constructors were migrated to protected.
  • There were a handful of package private methods (persist, reset, validate) that were migrated to public as some of the subclasses had overridden the methods with public modifier.

These changes will enable consumers to create custom Field and SimpleControl subclasses without having to place their classes in the same package as the original FormsFX classes (a big no-no in modular codebases as split-package definition is prohibited!).

In my experience implementing a library with package private in mind makes it quite hard for consumers to fill in gaps with custom implementations, it would be better to keep our options open (protected) but not wildly open (public). Of course the usage of package private is a matter of taste and particular design goals that may not (or appear not to) be explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants