Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch implementation from Field to Element #40

Closed
martinfrancois opened this issue Sep 6, 2018 · 0 comments · Fixed by #99
Closed

Switch implementation from Field to Element #40

martinfrancois opened this issue Sep 6, 2018 · 0 comments · Fixed by #99
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@martinfrancois
Copy link
Contributor

martinfrancois commented Sep 6, 2018

As of FormsFX 1.3.0, introduced by dlsc-software-consulting-gmbh/FormsFX#28 a Field is now a subclass of Element. From PreferencesFX 2.1.0, the included dependency of FormsFX has been updated to 1.3.0, but still only Field is supported and not Element.
By using Field we are limited in terms of the features of FormsFX we and also the API user can use and thereby benefit from.

This change would involve replacing all occurences of Field with Element and to also expose Element instead of Field externally. Currently, a quick fix is in place (#39), which casts the Element objects to Fields. Going with Element internally instead of Field eliminates the need for a cast and opens up additional features which can then be used for custom controls and also to expose additional functionality with PreferencesFX.

Migrating to the new architecture of FormsFX makes sense, but since PreferencesFX makes heavy use of FormsFX, also using custom renderers and controls to change a lot of the behavior of FormsFX, this is not an easy task, while still preserving the original functionality as currently implemented by PreferencesFX.

@martinfrancois martinfrancois added enhancement New feature or request help wanted Extra attention is needed labels Sep 6, 2018
@Genron Genron closed this as completed in #99 Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant