Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open SimpleControl impls for extension #27

Closed
aalmiray opened this issue Jul 10, 2018 · 1 comment
Closed

Open SimpleControl impls for extension #27

aalmiray opened this issue Jul 10, 2018 · 1 comment

Comments

@aalmiray
Copy link
Contributor

I have the need to change the renderer of a StringField. While I can create a custom implementation of SimpleControlsimilar to SimpleTextControlI'd have to duplicate code as the SimpleTextControl defines most of its state & behavior using the private visibility modifier.

It would be better to migrate to protected, applying the factory method pattern where it makes sense, allowing subclasses to override specific behavior.
@aalmiray aalmiray mentioned this issue Jul 10, 2018
Merged
@aalmiray
Copy link
Contributor Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aalmiray