Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: @packages/runner-shared should also be devDependencies #17133

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

tgriesser
Copy link
Member

Additional details

Continues on the work of #17100 moving code that doesn't need to be included in the "production" build into devDependencies.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 28, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 28, 2021



Test summary

18174 0 214 7Flakiness 5


Run details

Project cypress
Status Passed
Commit b2b97ed
Started Jun 29, 2021 1:41 PM
Ended Jun 29, 2021 1:53 PM
Duration 12:19 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
3 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
4 network stubbing > intercepting request > should delay the same amount on every response
retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@lmiller1990
Copy link
Contributor

Percy screenshots fails are a little suspicious - I wonder how/when these were introduced 🤔

* develop:
  fix: plugin file in angular schematics (#17141)
  chore(runner): render spec list inline (behind feature flag) (#17069)
  refactor: remove junk test (#17125)
  chore(server): collapse project-ct and project-e2e into project-base (#17115)
  chore: release @cypress/schematic-v1.4.0
@tgriesser tgriesser merged commit 7276f5e into develop Jun 29, 2021
@tgriesser tgriesser deleted the tgriesser/chore/more-reduce-dependencies branch June 29, 2021 15:15
tgriesser added a commit that referenced this pull request Jun 29, 2021
* develop:
  fix: plugin file referenced by cypress config in angular schematics (#17143)
  refactor: @packages/runner-shared should also be devDependencies (#17133)
  chore: release @cypress/schematic-v1.4.1
  fix: plugin file in angular schematics (#17141)
  chore(runner): render spec list inline (behind feature flag) (#17069)
  refactor: remove junk test (#17125)
  chore(server): collapse project-ct and project-e2e into project-base (#17115)
  chore: release @cypress/schematic-v1.4.0
tgriesser added a commit that referenced this pull request Jun 30, 2021
* develop:
  fix: prevent saved state errors for deprecated keys (#17093)
  fix(studio): restore intro modal styles (#17118)
  refactor: add @packages/resolve-dist to isolate client/server code (#17109)
  fix: plugin file referenced by cypress config in angular schematics (#17143)
  refactor: @packages/runner-shared should also be devDependencies (#17133)
  chore: release @cypress/schematic-v1.4.1
  fix: plugin file in angular schematics (#17141)
  chore(runner): render spec list inline (behind feature flag) (#17069)
  refactor: remove junk test (#17125)
  chore(server): collapse project-ct and project-e2e into project-base (#17115)
  fix: make dev-server error message appear only once when CT is not configured (#17090)
  chore: release @cypress/schematic-v1.4.0
  feat: add ng generate to @cypress/schematic to generate e2e spec files (#16962)
  feat(studio): add ability to copy commands to clipboard (#16912)
  chore: release @cypress/webpack-preprocessor-v5.9.1
  chore: release @cypress/webpack-batteries-included-preprocessor-v2.2.2
  chore: release @cypress/vue-v3.0.0-beta.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants