Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent saved state errors for deprecated keys #17093

Merged
merged 6 commits into from
Jun 30, 2021

Conversation

panzarino
Copy link
Contributor

@panzarino panzarino commented Jun 23, 2021

User facing changelog

  • Cypress will no longer show a warning about allowed keys for the showedOnBoardingModal when running cypress open

Additional details

Allows us to remove keys that are no longer being used without any errors being thrown

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 23, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jun 23, 2021



Test summary

18174 0 214 7Flakiness 1


Run details

Project cypress
Status Passed
Commit afb3cab
Started Jun 29, 2021 8:33 PM
Ended Jun 29, 2021 8:44 PM
Duration 10:59 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@panzarino panzarino changed the title chore: prevent saved state errors for deprecated keys fix: prevent saved state errors for deprecated keys Jun 25, 2021
@panzarino panzarino marked this pull request as ready for review June 25, 2021 13:26
@panzarino panzarino requested a review from a team as a code owner June 25, 2021 13:26
@jennifer-shehane jennifer-shehane requested review from kuceb and removed request for a team and flotwig June 25, 2021 13:42
@jennifer-shehane jennifer-shehane merged commit 5579a48 into develop Jun 30, 2021
tgriesser added a commit that referenced this pull request Jun 30, 2021
* develop:
  fix: prevent saved state errors for deprecated keys (#17093)
  fix(studio): restore intro modal styles (#17118)
  refactor: add @packages/resolve-dist to isolate client/server code (#17109)
  fix: plugin file referenced by cypress config in angular schematics (#17143)
  refactor: @packages/runner-shared should also be devDependencies (#17133)
  chore: release @cypress/schematic-v1.4.1
  fix: plugin file in angular schematics (#17141)
  chore(runner): render spec list inline (behind feature flag) (#17069)
  refactor: remove junk test (#17125)
  chore(server): collapse project-ct and project-e2e into project-base (#17115)
  fix: make dev-server error message appear only once when CT is not configured (#17090)
  chore: release @cypress/schematic-v1.4.0
  feat: add ng generate to @cypress/schematic to generate e2e spec files (#16962)
  feat(studio): add ability to copy commands to clipboard (#16912)
  chore: release @cypress/webpack-preprocessor-v5.9.1
  chore: release @cypress/webpack-batteries-included-preprocessor-v2.2.2
  chore: release @cypress/vue-v3.0.0-beta.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants