fix(studio): restore intro modal styles #17118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
|
@panzarino Looks like the percy snapshot doesn't reflect the image. Anything we can do about that? |
lmiller1990
previously approved these changes
Jun 25, 2021
panzarino
dismissed stale reviews from lmiller1990 and jennifer-shehane
via
c88cc78
|
Wasn't able to figure out a solution that would capture the gif properly - after searching a bit more we would probably have to modify the percy plugin setup to fix this which is out of scope here. For this PR it might actually be better that we consistently don't get it rendering so there's no flakiness from snapshotting different gif frames so I'd say we should push it through as is. |
lmiller1990
approved these changes
Jun 30, 2021
tgriesser
added a commit
that referenced
this pull request
Jun 30, 2021
* develop: fix: prevent saved state errors for deprecated keys (#17093) fix(studio): restore intro modal styles (#17118) refactor: add @packages/resolve-dist to isolate client/server code (#17109) fix: plugin file referenced by cypress config in angular schematics (#17143) refactor: @packages/runner-shared should also be devDependencies (#17133) chore: release @cypress/schematic-v1.4.1 fix: plugin file in angular schematics (#17141) chore(runner): render spec list inline (behind feature flag) (#17069) refactor: remove junk test (#17125) chore(server): collapse project-ct and project-e2e into project-base (#17115) fix: make dev-server error message appear only once when CT is not configured (#17090) chore: release @cypress/schematic-v1.4.0 feat: add ng generate to @cypress/schematic to generate e2e spec files (#16962) feat(studio): add ability to copy commands to clipboard (#16912) chore: release @cypress/webpack-preprocessor-v5.9.1 chore: release @cypress/webpack-batteries-included-preprocessor-v2.2.2 chore: release @cypress/vue-v3.0.0-beta.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
Most likely something got lost in the runner unification work - I've added a more explicit Cypress test with Percy so that this doesn't happen again (looks like we had only been doing enzyme previously)
PR Tasks