-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ng generate to @cypress/schematic to generate e2e spec files #16962
Conversation
DX-371 Add ng-generate schematic to generate e2e tests
If user runs |
Thanks for taking the time to open a PR!
|
04b7c50
to
93e22b9
Compare
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
bcd856b
to
4c6582b
Compare
d9963ec
to
f527a6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice. Is there any way for the user to type something shorter than @cypress/schematic:e2e
? Any alias functionality available here?
@amirrustam that would be great. As I understand it the only part that can be aliased is after the schematic name |
f527a6f
to
9a19d32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see comment
@@ -0,0 +1,4 @@ | |||
describe('<%= classify(name) %>', () => { | |||
it('', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe providing an example assertion or some kind of comment might be useful here? I'm not sure. It might be cruft. I'm thinking that the other files that Cypress scaffolds out of the box (when you run cypress open
in a new project for the first time) are littered with comments. This seems fine to me though, because do they really need anything more than this in a scaffolded new test?
Other than this one food-for-thought, I think that everything here LGTM.
* develop: fix: prevent saved state errors for deprecated keys (#17093) fix(studio): restore intro modal styles (#17118) refactor: add @packages/resolve-dist to isolate client/server code (#17109) fix: plugin file referenced by cypress config in angular schematics (#17143) refactor: @packages/runner-shared should also be devDependencies (#17133) chore: release @cypress/schematic-v1.4.1 fix: plugin file in angular schematics (#17141) chore(runner): render spec list inline (behind feature flag) (#17069) refactor: remove junk test (#17125) chore(server): collapse project-ct and project-e2e into project-base (#17115) fix: make dev-server error message appear only once when CT is not configured (#17090) chore: release @cypress/schematic-v1.4.0 feat: add ng generate to @cypress/schematic to generate e2e spec files (#16962) feat(studio): add ability to copy commands to clipboard (#16912) chore: release @cypress/webpack-preprocessor-v5.9.1 chore: release @cypress/webpack-batteries-included-preprocessor-v2.2.2 chore: release @cypress/vue-v3.0.0-beta.3
User facing changelog
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?