fix: semver comparison #216
Conversation
chore: bump dependencies
Cherry
force-pushed
the
fix/semver-check
branch
2 times, most recently
from
2dbf0c7
to
c559f04
Compare
Cherry
force-pushed
the
fix/semver-check
branch
from
c559f04
to
efb84b0
Compare
|
Not sure what's up with the test failure here, that's not one that I touched 🤔 Seems like the test is doing what it expected, but not checking for the right error type? |
|
The failed test is due to updating vitest to v1, which contains this breaking change: vitest-dev/vitest#4396. The resolution is just to fix up the snapshot to match the new expected value. |
petebacondarwin
added
awaiting reporter response
and removed
awaiting Cloudflare response
labels
lrapoport-cf
added
awaiting Cloudflare response
and removed
awaiting reporter response
labels
|
Great catch, thanks @petebacondarwin. I've updated that now and all should be good. |
|
Hmm. The failing tests need to be run on our fork since they require secrets... |
|
Yeah I can't really fix that one unfortunately 😞 I've not made any real changes to the deploy process of this, but let me know if I can assist with anything further here to get this merged. |
|
Well that is interesting! By pushing a branch with the exact commit from this PR in it, the CI tests ran and Github attributed the successful test run to this PR too! TIL! All good to go. Thanks @Cherry |
fixes #215
closes #214
This also bumps a few dependencies, to remove some
npm auditwarnings. The output bundle increases from964kBto983kB, but I feel the 19kB increase is worth the reliable semver comparison.