Skip to content

Commit

Permalink
chore: add changeset
Browse files Browse the repository at this point in the history
  • Loading branch information
Cherry committed Dec 9, 2023
1 parent fe8fdd7 commit efb84b0
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .changeset/weak-lobsters-march.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"wrangler-action": patch
---

Fixes issues with semver comparison, where version parts were treated lexicographically instead of numerically.

Bulk secret uploading was introduced in wrangler `3.4.0`, and this action tries to check if the version used is greater than `3.4.0`, and then if so, using the new bulk secret API which is faster. Due to a bug in the semver comparison, `3.19.0` was being considered less than `3.4.0`, and then using an older and slower method for uploading secrets.

Now the semver comparison is fixed, the faster bulk method is used for uploading secrets when available.

0 comments on commit efb84b0

Please sign in to comment.