Fix spelling of Python 3.5-specific requirements #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjwatson
force-pushed
the
fix-py35-requirements
branch
from
fb2f7ed
to
451e03a
Compare
According to PEP 440, `~="3.5"` is equivalent to `>="3.5", =="3.*"` - that is, any 3.x version from 3.5 on. I don't think that's what was intended in most of these cases, and the effect is that resolvers on recent versions of Python end up pinning to the versions that work on 3.5, which is pretty excessive. In most of these cases, `~="3.5.0"` is a better spelling, restricting these pins to Python 3.5.x. The exceptions seem to be `aiocontextvars` and `contextvars`, which were needed in Python 3.5 and 3.6, but aren't needed as of 3.7 since `contextvars` is in the standard library there; I think `>="3.5"` plus `<"3.7"` and similar makes more sense for those cases. (Comments in `talisker.context` indicate that `aiocontextvars` specifically requires at least 3.5.3.)
cjwatson
force-pushed
the
fix-py35-requirements
branch
from
451e03a
to
9b40b9c
Compare
tox 4 drops Python 3.6 support, which is inconvenient.
cjwatson
force-pushed
the
fix-py35-requirements
branch
from
6d042bf
to
4df97e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to PEP 440,
~="3.5"is equivalent to>="3.5", =="3.*"- that is, any 3.x version from 3.5 on. I don't think that's what was intended in most of these cases, and the effect is that resolvers on recent versions of Python end up pinning to the versions that work on 3.5, which is pretty excessive.In most of these cases,
~="3.5.0"is a better spelling, restricting these pins to Python 3.5.x. The exceptions seem to beaiocontextvarsandcontextvars, which were needed in Python 3.5 and 3.6, but aren't needed as of 3.7 sincecontextvarsis in the standard library there; I think>="3.5"plus<"3.7"and similar makes more sense for those cases. (Comments intalisker.contextindicate thataiocontextvarsspecifically requires at least 3.5.3.)