-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix spelling of Python 3.5-specific requirements
According to PEP 440, `~="3.5"` is equivalent to `>="3.5", =="3.*"` - that is, any 3.x version from 3.5 on. I don't think that's what was intended in most of these cases, and the effect is that resolvers on recent versions of Python end up pinning to the versions that work on 3.5, which is pretty excessive. In most of these cases, `~="3.5.0"` is a better spelling, restricting these pins to Python 3.5.x. The exceptions seem to be `aiocontextvars` and `contextvars`, which were needed in Python 3.5 and 3.6, but aren't needed as of 3.7 since `contextvars` is in the standard library there; I think `>="3.5"` plus `<"3.7"` and similar makes more sense for those cases. (Comments in `talisker.context` indicate that `aiocontextvars` specifically requires at least 3.5.3.)
- Loading branch information
Showing
2 changed files
with
20 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters