Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of Python 3.5-specific requirements #591

Merged
merged 5 commits into from
Jan 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
sudo apt update
cat dependencies.txt | xargs sudo apt install -y
python -m pip install --upgrade pip
pip install tox tox-gh-actions
pip install 'tox<4' 'tox-gh-actions<3'
- name: Start redis
run: sudo systemctl start redis-server
- name: Setup tox, dependencies, and run tests
Expand Down
2 changes: 2 additions & 0 deletions requirements.tests.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ eventlet==0.30.2;python_version<"3.10"
eventlet>0.33;python_version>="3.10"
gevent==20.9.0;python_version<"3.10"
gevent>21;python_version>="3.10"
# ABI change, incompatible with gevent<22.10.2
greenlet<2;python_version<"3.10"
# the bottom pin is for limbo test runs, as latest version doesn't work with
# newer celery versions
redis>=3.2.0
Expand Down
24 changes: 12 additions & 12 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -42,31 +42,31 @@ packages = talisker
test_suite = tests
package_dir = talisker=talisker
install_requires =
Werkzeug~=1.0;python_version~="3.5"
Werkzeug<3;python_version>"3.6"
statsd~=3.3;python_version~="3.5"
statsd<4;python_version>"3.6"
requests~=2.25;python_version~="3.5"
Werkzeug~=1.0;python_version~="3.5.0"
Werkzeug<3;python_version>="3.6"
statsd~=3.3;python_version~="3.5.0"
statsd<4;python_version>="3.6"
requests~=2.25;python_version~="3.5.0"
requests<3.0;python_version>"3.5"
future~=0.18
contextvars~=2.4;python_version~="3.5"
contextvars~=2.4;python_version>="3.5" and python_version<"3.7"

[options.extras_require]
gunicorn = gunicorn>=19.7.0
raven = raven>=6.4.0
celery =
celery~=4.4;python_version~="3.5"
celery~=4.4;python_version~="3.5.0"
celery>=4,<5.3;python_version>"3.5"
django =
django~=2.2;python_version~="3.5"
django~=2.2;python_version~="3.5.0"
django<4;python_version>"3.5"
prometheus =
prometheus-client~=0.7.0;python_version~="3.5"
prometheus-client~=0.7.0;python_version~="3.5.0"
prometheus-client<0.8;python_version>"3.5"
flask =
flask~=1.1;python_version~="3.5"
flask~=1.1;python_version~="3.5.0"
flask<3;python_version>"3.5"
blinker~=1.5;python_version~="3.5"
blinker~=1.5;python_version~="3.5.0"
blinker<2;python_version>"3.5"
dev =
logging_tree>=1.9
Expand All @@ -77,7 +77,7 @@ pg =
sqlparse>=0.4.2
psycopg2>=2.8,<3.0
asyncio =
aiocontextvars==0.2.2;python_version~="3.5"
aiocontextvars==0.2.2;python_version>="3.5.3" and python_version<"3.7"
gevent = gevent>=20.9.0

[options.package_data]
Expand Down
24 changes: 12 additions & 12 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,10 @@
),
extras_require=dict(
asyncio=[
'aiocontextvars==0.2.2;python_version~="3.5"',
'aiocontextvars==0.2.2;python_version>="3.5.3" and python_version<"3.7"',
],
celery=[
'celery~=4.4;python_version~="3.5"',
'celery~=4.4;python_version~="3.5.0"',
'celery>=4,<5.3;python_version>"3.5"',
],
dev=[
Expand All @@ -155,13 +155,13 @@
'objgraph>=3.5',
],
django=[
'django~=2.2;python_version~="3.5"',
'django~=2.2;python_version~="3.5.0"',
'django<4;python_version>"3.5"',
],
flask=[
'flask~=1.1;python_version~="3.5"',
'flask~=1.1;python_version~="3.5.0"',
'flask<3;python_version>"3.5"',
'blinker~=1.5;python_version~="3.5"',
'blinker~=1.5;python_version~="3.5.0"',
'blinker<2;python_version>"3.5"',
],
gevent=[
Expand All @@ -175,7 +175,7 @@
'psycopg2>=2.8,<3.0',
],
prometheus=[
'prometheus-client~=0.7.0;python_version~="3.5"',
'prometheus-client~=0.7.0;python_version~="3.5.0"',
'prometheus-client<0.8;python_version>"3.5"',
],
raven=[
Expand All @@ -184,14 +184,14 @@
),
include_package_data=True,
install_requires=[
'Werkzeug~=1.0;python_version~="3.5"',
'Werkzeug<3;python_version>"3.6"',
'statsd~=3.3;python_version~="3.5"',
'statsd<4;python_version>"3.6"',
'requests~=2.25;python_version~="3.5"',
'Werkzeug~=1.0;python_version~="3.5.0"',
'Werkzeug<3;python_version>="3.6"',
'statsd~=3.3;python_version~="3.5.0"',
'statsd<4;python_version>="3.6"',
'requests~=2.25;python_version~="3.5.0"',
'requests<3.0;python_version>"3.5"',
'future~=0.18',
'contextvars~=2.4;python_version~="3.5"',
'contextvars~=2.4;python_version>="3.5" and python_version<"3.7"',
],
keywords=[
'talisker',
Expand Down
3 changes: 3 additions & 0 deletions tests/test_endpoints.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import talisker.statsd
import talisker.endpoints
from talisker.endpoints import StandardEndpointMiddleware
from talisker.util import pkg_is_installed

from tests.test_metrics import counter_name

Expand Down Expand Up @@ -330,6 +331,8 @@ def test_info_workers():


def test_info_objgraph():
if not pkg_is_installed('objgraph'):
pytest.skip('objgraph not installed')
client = get_client()
response = client.get('/_status/info/objgraph',
environ_overrides={'REMOTE_ADDR': b'127.0.0.1'})
Expand Down
4 changes: 3 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ python =

[testenv]
usedevelop = True
deps = -r{toxinidir}/requirements.tests.txt
deps =
-r{toxinidir}/requirements.tests.txt
{toxinidir}
commands = py.test -v --cov=talisker --no-success-flaky-report
extras =
gunicorn
Expand Down